Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hero product whats new - #263 #384

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

webdevNYC
Copy link
Contributor

Pull request for Issue #263: Product Features - What's New. I may need to make some small adjustments, but I would appreciate it if we could merge this request before October 31 for Hacktoberfest.

@webdevNYC webdevNYC temporarily deployed to preview-deployment October 27, 2024 23:48 — with GitHub Actions Inactive
Copy link

🚀 Preview deployed to: https://52c259d7.animata.pages.dev

@webdevNYC webdevNYC changed the title Product Features - Whats New - #263 feat: hero product whats new - #263 Oct 28, 2024
@hari
Copy link
Contributor

hari commented Oct 28, 2024

@webdevNYC The content is stretching. You can fix this using layoutId correctly.
https://www.framer.com/motion/layout-animations/###the-content-stretches-undesirably

@webdevNYC webdevNYC temporarily deployed to preview-deployment October 28, 2024 15:27 — with GitHub Actions Inactive
@webdevNYC
Copy link
Contributor Author

webdevNYC commented Oct 28, 2024

Hi, I'm not sure if I fixed the motion you're looking for. Please let me know which motion is bothering you the most. Also, I'll try to review it later.

Copy link

🚀 Preview deployed to: https://15d72fac.animata.pages.dev

@webdevNYC
Copy link
Contributor Author

Please hold off on reviewing this ticket; I'm working on a new version.

@webdevNYC
Copy link
Contributor Author

I'm afraid I'll have to give it up. I had a good time yesterday working on the layout and experimenting with new ideas, but in the end, it didn’t work out. This is my first time using Framer Motion, and I think I've been mixing too many Tailwind classes with the motion components. I prefer someone with more experience to take over. I'm sorry about that. Next time, I'll stick to simple tasks. I plan to keep contributing since I really enjoy React, Tailwind, and Framer Motion.

@hari
Copy link
Contributor

hari commented Oct 31, 2024

@webdevNYC No worries. Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants