Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add form-control-switch button #383

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

CBID2
Copy link

@CBID2 CBID2 commented Oct 26, 2024

Description

This PR adds a form control switch button and its corresponding documentation.

Issue

Closes #215

Screenshot

@CBID2 CBID2 had a problem deploying to preview-deployment October 26, 2024 19:57 — with GitHub Actions Failure
@CBID2 CBID2 marked this pull request as draft October 26, 2024 20:05
@CBID2 CBID2 had a problem deploying to preview-deployment October 26, 2024 22:09 — with GitHub Actions Failure
@CBID2 CBID2 had a problem deploying to preview-deployment October 26, 2024 22:14 — with GitHub Actions Failure
@CBID2 CBID2 temporarily deployed to preview-deployment October 26, 2024 22:16 — with GitHub Actions Inactive
@CBID2 CBID2 temporarily deployed to preview-deployment October 26, 2024 22:22 — with GitHub Actions Inactive
@CBID2 CBID2 marked this pull request as ready for review October 26, 2024 22:23
@CBID2
Copy link
Author

CBID2 commented Oct 26, 2024

Hi @sudhashrestha. I made the PR! :)

Copy link

🚀 Preview deployed to: https://16f84fed.animata.pages.dev

Copy link

🚀 Preview deployed to: https://e82709a9.animata.pages.dev

@hari
Copy link
Contributor

hari commented Oct 28, 2024

@CBID2 Could you review the design and try to match the animations? You don't need to animate the icons, just make it look like the design and animate the position.

@CBID2 CBID2 had a problem deploying to preview-deployment October 28, 2024 23:29 — with GitHub Actions Failure
@CBID2
Copy link
Author

CBID2 commented Oct 29, 2024

@CBID2 Could you review the design and try to match the animations? You don't need to animate the icons, just make it look like the design and animate the position.

Hi @hari. I made some changes but I'm struggling with seeing the design because it's not deployed. Can you help with this please?

@CBID2 CBID2 had a problem deploying to preview-deployment October 29, 2024 23:22 — with GitHub Actions Failure
@hari
Copy link
Contributor

hari commented Oct 31, 2024

@CBID2 The build is failing:


./animata/button/form-control-switch.stories.tsx:1:8
Type error: Module '"/home/runner/work/animata/animata/animata/button/form-control-switch"' has no default export. Did you mean to use 'import { FormControlSwitch } from "/home/runner/work/animata/animata/animata/button/form-control-switch"' instead?

> 1 | import FormControlSwitch from "@/animata/button/form-control-switch";
    |        ^
  2 | import { Meta, StoryObj } from "@storybook/react";

Copy link
Author

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this clear

animata/button/form-control-switch.stories.tsx Outdated Show resolved Hide resolved
@CBID2 CBID2 had a problem deploying to preview-deployment October 31, 2024 08:09 — with GitHub Actions Failure
@CBID2
Copy link
Author

CBID2 commented Oct 31, 2024

@CBID2 The build is failing:




./animata/button/form-control-switch.stories.tsx:1:8

Type error: Module '"/home/runner/work/animata/animata/animata/button/form-control-switch"' has no default export. Did you mean to use 'import { FormControlSwitch } from "/home/runner/work/animata/animata/animata/button/form-control-switch"' instead?



> 1 | import FormControlSwitch from "@/animata/button/form-control-switch";

    |        ^

  2 | import { Meta, StoryObj } from "@storybook/react";

Fixed it @hari

@hari
Copy link
Contributor

hari commented Nov 1, 2024

@CBID2 it is still failing with TS error on the storybook.

Signed-off-by: Christine <[email protected]>
@CBID2 CBID2 had a problem deploying to preview-deployment November 7, 2024 21:19 — with GitHub Actions Failure
@CBID2
Copy link
Author

CBID2 commented Nov 7, 2024

@CBID2 it is still failing with TS error on the storybook.

I fixed it @hari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Control - Switch
2 participants