-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): create new PR for Hero Button as previous PR failed the… #377
base: main
Are you sure you want to change the base?
Conversation
@hari @sudhashrestha , I have opened a new PR for the Issue number #367, and this PR is just the improved version of #373 @hari sir , can you please review it and tell me what changes are required |
@hari sir, can you review this PR |
@NishantSinghhhhh build is failing:
|
okay sir correcting this one |
Signed-off-by: NishantSinghhhhh <[email protected]>
Signed-off-by: NishantSinghhhhh <[email protected]>
Signed-off-by: NishantSinghhhhh <[email protected]>
@hari ,Sir I have done the changes , now there will not be any problem in the build process |
New PR for Hero button