Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds scrub slider component #333 #371

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: adds scrub slider component #333 #371

wants to merge 4 commits into from

Conversation

sumedhakoranga
Copy link

@sumedhakoranga sumedhakoranga commented Oct 17, 2024 •
edited by sudhashrestha
Loading

Closes #333

@sumedhakoranga sumedhakoranga mentioned this pull request Oct 17, 2024
Open
@github-actions GitHub Actions
Copy link

🚀 Preview deployed to: https://85c2ac59.animata.pages.dev

@hari hari requested a review from sudhashrestha October 17, 2024 06:35
@hari hari linked an issue Oct 23, 2024 that may be closed by this pull request
Scrub slider #333
Open
@hari hari self-requested a review October 23, 2024 07:44
hari
hari requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumedhakoranga A few changes:

  1. The component's section is not registered. Please add the following line in config/docs.ts (after line: 178)
  {
    title: "Form controls",
    items: createLinks("form-controls"),
  },
  1. The value resets to the original value after the mouse leaves. Clicking on the scruber doesn't sustain the value as well.

@sumedhakoranga
Copy link
Author

@hari @sudhashrestha Hi, I have made the changes. Please check

@github-actions GitHub Actions
Copy link

🚀 Preview deployed to: https://50d4bf89.animata.pages.dev

@github-actions GitHub Actions
Copy link

🚀 Preview deployed to: https://ef40826c.animata.pages.dev

@sumedhakoranga
Copy link
Author

Hi, @hari, Could you please check the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hari hari hari requested changes

@sudhashrestha sudhashrestha Awaiting requested review from sudhashrestha

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrub slider
2 participants
@sumedhakoranga @hari