Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): add notification-reveal and documentation #361

Closed
wants to merge 2 commits into from

Conversation

Ajdecoder
Copy link

Description

created notification-reveal cards

Related Issue

closes #268

Change Type

Select the type of change:

  • πŸ› Bug fix
  • ✨ New feature
  • πŸ“š Documentation update
  • πŸ”§ Other (describe):

Checklist

  • I’ve read and followed the contributing guidelines.
  • Code adheres to project style and standards.
  • Tests cover changes (if applicable).
  • [] Documentation updated (if required).
  • Ready for review.

image

@Ajdecoder Ajdecoder temporarily deployed to preview-deployment October 10, 2024 06:31 — with GitHub Actions Inactive
@Ajdecoder
Copy link
Author

@hari please check for any potential issue?

Copy link

πŸš€ Preview deployed to: https://d01f804b.animata.pages.dev

Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation is not on point. The component needs to move up and then fade out.

Comment on lines +17 to +30

<Step>Update `tailwind.config.js`</Step>

Add the following to your tailwind.config.js file.

```json
module.exports = {
theme: {
extend: {
}
}
}
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this.

Comment on lines +50 to +53

Built by [Your name](https://github.com/YourGithubUsername)

...Add appropriate credits here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this and twitter username.

@@ -0,0 +1,53 @@
---
title: Notification Reveal
description: notification-reveal animation using framer motion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the description more descriptive and fix sentence.

@Ajdecoder Ajdecoder temporarily deployed to preview-deployment October 15, 2024 10:43 — with GitHub Actions Inactive
Copy link

πŸš€ Preview deployed to: https://9ebf4fd1.animata.pages.dev

@Ajdecoder Ajdecoder closed this by deleting the head repository Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications reveal
2 participants