Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice card issue #297 #356

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Notice card issue #297 #356

merged 6 commits into from
Oct 23, 2024

Conversation

AE-Hertz
Copy link
Contributor

@AE-Hertz AE-Hertz commented Oct 8, 2024

Created notice card and integrated it with storybook.

@AE-Hertz AE-Hertz temporarily deployed to preview-deployment October 8, 2024 17:13 — with GitHub Actions Inactive
@AE-Hertz AE-Hertz mentioned this pull request Oct 8, 2024
Copy link

github-actions bot commented Oct 9, 2024

🚀 Preview deployed to: https://649207b4.animata.pages.dev

@hari hari linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AE-Hertz The animation is not correct. Please review the video and update the animation.

@AE-Hertz
Copy link
Contributor Author

@hari i hope you were referring to background breathing type effect, i missed it earlier.

I fixed the effect, i hope now its same as required. Thank you

content/docs/card/notice-card.mdx Outdated Show resolved Hide resolved
animata/card/notice-card.tsx Outdated Show resolved Hide resolved
@AE-Hertz AE-Hertz temporarily deployed to preview-deployment October 17, 2024 05:22 — with GitHub Actions Inactive
@AE-Hertz AE-Hertz temporarily deployed to preview-deployment October 17, 2024 05:23 — with GitHub Actions Inactive
Copy link

🚀 Preview deployed to: https://b45d674a.animata.pages.dev

@AE-Hertz
Copy link
Contributor Author

@hari i resolved the change requests. have a look, thank you

Copy link

🚀 Preview deployed to: https://51125d85.animata.pages.dev

@hari hari merged commit 0dd1f09 into codse:main Oct 23, 2024
2 checks passed
@sudhashrestha sudhashrestha added the hacktoberfest This issue is a part of the Hacktoberfest event label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is a part of the Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notice with slider
3 participants