-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comment-reply): adds comment-reply card #347
Conversation
@prince981620 the UI is shifting, could you try to improve it? |
@hari recreated component from scratch fixing that shifting UI. please review |
🚀 Preview deployed to: https://b08ad2b1.animata.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince981620 Please fix the typo of reply
and use layoutId to improve the animation. https://www.framer.com/motion/layout-animations. You might also need an extra view to make the animation look like the one in the video.
hey @hari i have fixed the typo and also fixed the animation. kindly review. |
🚀 Preview deployed to: https://cb904473.animata.pages.dev |
@hari review ?? |
@prince981620 this is not responsive |
hey @hari added responsiveness to the input box. kindly review |
🚀 Preview deployed to: https://bcc1fa91.animata.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prince981620 We can improve the design a little bit, especially padding and spacing. You can create a new PR if you would like to, I am going to merge this.
@hari sure I will give it a try. |
Screen.Recording.2024-10-07.at.4.03.50.AM.mov
hey @hari i have added comment-reply component in card sections . please review