Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comment-reply): adds comment-reply card #347

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

prince981620
Copy link
Contributor

Screen.Recording.2024-10-07.at.4.03.50.AM.mov

hey @hari i have added comment-reply component in card sections . please review

@prince981620 prince981620 temporarily deployed to preview-deployment October 6, 2024 22:36 — with GitHub Actions Inactive
@hari
Copy link
Contributor

hari commented Oct 7, 2024

@prince981620 the UI is shifting, could you try to improve it?

@hari hari self-requested a review October 7, 2024 08:19
@prince981620 prince981620 temporarily deployed to preview-deployment October 7, 2024 19:26 — with GitHub Actions Inactive
@prince981620
Copy link
Contributor Author

@prince981620 the UI is shifting, could you try to improve it?

@hari recreated component from scratch fixing that shifting UI. please review

Copy link

github-actions bot commented Oct 8, 2024

🚀 Preview deployed to: https://b08ad2b1.animata.pages.dev

@hari hari linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prince981620 Please fix the typo of reply and use layoutId to improve the animation. https://www.framer.com/motion/layout-animations. You might also need an extra view to make the animation look like the one in the video.

@prince981620
Copy link
Contributor Author

@prince981620 Please fix the typo of reply and use layoutId to improve the animation. https://www.framer.com/motion/layout-animations. You might also need an extra view to make the animation look like the one in the video.

hey @hari i have fixed the typo and also fixed the animation. kindly review.

Copy link

🚀 Preview deployed to: https://cb904473.animata.pages.dev

@prince981620
Copy link
Contributor Author

@hari review ??

@hari
Copy link
Contributor

hari commented Oct 19, 2024

@prince981620 this is not responsive

@prince981620
Copy link
Contributor Author

@prince981620 this is not responsive

hey @hari added responsiveness to the input box. kindly review

Copy link

🚀 Preview deployed to: https://bcc1fa91.animata.pages.dev

Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prince981620 We can improve the design a little bit, especially padding and spacing. You can create a new PR if you would like to, I am going to merge this.

@hari hari merged commit ccf0ce5 into codse:main Oct 23, 2024
2 checks passed
@prince981620
Copy link
Contributor Author

@prince981620 We can improve the design a little bit, especially padding and spacing. You can create a new PR if you would like to, I am going to merge this.

@hari sure I will give it a try.

@sudhashrestha sudhashrestha added the hacktoberfest This issue is a part of the Hacktoberfest event label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is a part of the Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment reply
3 participants