Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pills): add scattered pills feature and resolve issue #238 #336

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

raghav3615
Copy link
Contributor

@raghav3615 raghav3615 commented Oct 5, 2024

Closes #238 - feat(pills): Scattered Pills
@sudhashrestha @hari kindly review it

Checklist:
I have read and followed the contributing guidelines.
I have developed the component according to the requirements.
I have tested the component across different browsers and screen sizes.
I have documented the component for future reference.
I have submitted a pull request with appropriate labels and referenced this issue number.

@hari
Copy link
Contributor

hari commented Oct 5, 2024

@raghav3615 this should be inside ‘feature cards’

animata/pills/scattered-pills.tsx Outdated Show resolved Hide resolved
content/docs/pills/scattered-pills.mdx Outdated Show resolved Hide resolved
animata/pills/scattered-pills.tsx Outdated Show resolved Hide resolved
@raghav3615 raghav3615 requested a review from hari October 5, 2024 13:52
@raghav3615
Copy link
Contributor Author

@hari kindly review this

@hari
Copy link
Contributor

hari commented Oct 6, 2024

@raghav3615 could you please sync your branch with the latest changes from the main?

@raghav3615
Copy link
Contributor Author

@hari done

@hari hari closed this Oct 6, 2024
@hari hari reopened this Oct 6, 2024
@hari hari temporarily deployed to preview-deployment October 6, 2024 15:54 — with GitHub Actions Inactive
animata/card/scattered-pills.tsx Outdated Show resolved Hide resolved
@raghav3615 raghav3615 temporarily deployed to preview-deployment October 6, 2024 16:02 — with GitHub Actions Inactive
@raghav3615 raghav3615 requested a review from hari October 6, 2024 16:04
@hari
Copy link
Contributor

hari commented Oct 7, 2024

@raghav3615 The implementation is still not correct. You don't need any state for that, I understand it could be not very clear from the video. Here's how it should work

  1. The items are rotated by default
  2. On group hover, the rotation of the item should be set to 0
  3. When hovering over each item, they need to scale.

Also, please use symmetric vertical padding i.e. py-24 instead of pt-24, and reduce the value in small devices.

That is all we need and can be accomplished using CSS only.

Copy link
Contributor

@hari hari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment above :)

@sudhashrestha
Copy link
Contributor

Hi @raghav3615

I hope you're doing well! Since it's been a while since this PR was reviewed, I wanted to check in and see if you're still planning to work on it. If so, could you kindly share an update by tomorrow?

If I don't hear back by then, I’ll unassign the issue to allow others to take it up.

Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scattered pills
3 participants