-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pills): add scattered pills feature and resolve issue #238 #336
base: main
Are you sure you want to change the base?
Conversation
@raghav3615 this should be inside ‘feature cards’ |
@hari kindly review this |
@raghav3615 could you please sync your branch with the latest changes from the main? |
@hari done |
@raghav3615 The implementation is still not correct. You don't need any state for that, I understand it could be not very clear from the video. Here's how it should work
Also, please use symmetric vertical padding i.e. That is all we need and can be accomplished using CSS only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment above :)
Hi @raghav3615 I hope you're doing well! Since it's been a while since this PR was reviewed, I wanted to check in and see if you're still planning to work on it. If so, could you kindly share an update by tomorrow? If I don't hear back by then, I’ll unassign the issue to allow others to take it up. Thanks for your understanding! |
Closes #238 - feat(pills): Scattered Pills
@sudhashrestha @hari kindly review it
Checklist:
I have read and followed the contributing guidelines.
I have developed the component according to the requirements.
I have tested the component across different browsers and screen sizes.
I have documented the component for future reference.
I have submitted a pull request with appropriate labels and referenced this issue number.