Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 contributing.md #884

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Patch 1 contributing.md #884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dd722c
Update CONTRIBUTING.md
JeanGarf Jan 5, 2020
3b5ef73
Add info about Windows
JeanGarf Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ GnuCash Android is built by people like you! Please [join us](https://github.com
## Code Contributions
* Contributions are submitted, reviewed, and accepted using Github pull requests. [Read this article](https://help.github.com/articles/using-pull-requests) for some details. We use the _Fork and Pull_ model, as described there.
* You can maintain your stable installation of GnuCash and test with another installation.
The two instances of GnuCash Android will live side-by-side on your device and not affect each other. You can install the development version by executing `gradle installDD` inside the root project directory
The two instances of GnuCash Android will live side-by-side on your device and not affect each other. You can install the development version by executing `gradlew installDevelopmentDebug` inside the root project directory
* The latest changes are in the `develop` branch.
* Always rebase develop before working on a fix or issuing a pull request
* The master branch contains only stable releases.
Expand All @@ -23,7 +23,7 @@ The two instances of GnuCash Android will live side-by-side on your device and n
* Make a new branch for every feature you're working on.
* Try to make clean commits that are easily readable (including descriptive commit messages!)
* Test before you push make sure all test pass on your machine.
* Unit tests can be run with `gradle test`
* Unit tests can be run with `gradle test` or (`gradlew test` on Windows)
* UI tests can be run with `gradle spoonDD`. This will run the tests on all connected devices/emulators.
* Make small pull requests that are easy to review but which also add value.

Expand Down