Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split balance error if one split is a liability, Equity or an Income #876

Open
JeanGarf opened this issue Feb 29, 2020 · 0 comments
Open

Split balance error if one split is a liability, Equity or an Income #876

JeanGarf opened this issue Feb 29, 2020 · 0 comments

Comments

@JeanGarf
Copy link

JeanGarf commented Feb 29, 2020 •
edited
Loading

Steps to reproduce the behaviour

Create a transaction like this
wallet : credit 85
food : debit 60
gasoline : debit 25

Balance is 0. That's OK

Now change gasoline to account Jean (whose type is liability, Equity or an Income)

Expected behaviour

Balance is 0

Actual behaviour

Balance is 50

Software specifications

  • GnuCash Android version: 2.4.1 85704b4
  • System Android version:
  • Device type:
@JeanGarf JeanGarf changed the title Split balance error if one split is a liability Split balance error if one split is a liability, Equity or an Income Feb 29, 2020
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Feb 29, 2020
@JeanGarf
Fixes codinguser#876 - Take into account only splitTypeSwitch to comp…
301b3c6 
…ute Split Balance
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 2, 2020
@JeanGarf
codinguser#876 - French Translation
931bde4
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 2, 2020
@JeanGarf
codinguser#876 - Correct errors in debit/credit labels vs GnuCash Win…
5367a26 
…dows. isChecked() : true == CREDIT. CREDIT => red, DEBIT => green
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 2, 2020
@JeanGarf
codinguser#876 - Computing Balance : Debit => +, Credit => -
b2ea8a0
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 2, 2020
@JeanGarf
codinguser#876 - hasDebitNormalBalance should not invert amount signum
6615458
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Create AccountUtils
4c84125
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Enhance Code Quality
9e1951f
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Set red/green color according to decrease/increase b…
c329455 
…alance (and not more debit/credit)
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Move attributes from ColorizeOnTransactionTypeChange…
02e6a02 
…Listener to TransactionTypeSwitch
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Create setViewsToColorize(...) to initialize views t…
e7f8d6f 
…o colorize in red/green
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Use setViewsToColorize(...) to initialize views to c…
f507e59 
…olorize in red/green
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - In transaction form, put the split button to the rig…
6ed4930 
…ht, like for transaction without splits
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 4, 2020
@JeanGarf
codinguser#876 - Renamings and TODO
b44c207
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Add AccountType parameter in displayBalance(...)
b7c042f
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - use displayBalance(...) with AccountType
e178e3a
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Correct balance amount computation and factorize int…
2f82436 
…o getAmountColor()
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Explain that balance in DetailTransactionActivity is…
52f59ef 
… computed at the date indicated below
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Enhance Code Quality
b31daad
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Fix merge
59d6b2d
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Replace mAssetAccountTypes with ASSET_ACCOUNT_TYPES …
bf49482 
…from AccountType
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Code quality
8e04ba5
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Transfer displayBalance(...) into AccountType and ma…
535e3d5 
…ke methods non static
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Use AccountType.displayBalance(...)
8844002
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Enhance Code Quality
cd0916b
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Rename mValue to mAmountAbsValue and use setter to e…
e9ab836 
…nsure storing of absolute values in splits
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Add shallDisplayAbsValue parameter in displayBalance…
23790c8 
…(...)
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - TransactionTypeSwitch does not change amount signum …
c0bf48d 
…anymore
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 7, 2020
@JeanGarf
codinguser#876 - Display amount absolute value when TransactionTypeSw…
6821ba7 
…itch is visible
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Mar 8, 2020
@JeanGarf
codinguser#876 - Add preference key_display_negative_signum_in_splits
bc27e47
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue May 24, 2020
@JeanGarf
codinguser#876 - In Splits Editor, display imbalance as if account is…
b59e69b 
… an asset
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue May 24, 2020
@JeanGarf
codinguser#876 - Fix import
82e17d4
John-Yu added a commit to John-Yu/gnucash-android that referenced this issue May 25, 2020
@John-Yu
codinguser#876 - Use different colors for balance, according to Accou…
a50a44d
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue May 28, 2020
@JeanGarf
codinguser#876 - Fix NPE when type switching on a new transaction
eb0f00d
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 10, 2020
@JeanGarf
codinguser#876 - Set amount to 0 if text field is empty
7fc3485
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 13, 2020
@JeanGarf
codinguser#876 - Rename mTransactionsAdapter into mTransactionsDbAdapter
a1626c1
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 13, 2020
@JeanGarf
codinguser#876 - Invert finish() and BookUtils.loadBook
5db92fb
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 13, 2020
@JeanGarf
codinguser#876 - Logs and comments
453252e
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - ** Allow null to enter SplitEditor + Transfert if fr…
3e333ec 
…om TransactionFormFragment.extractSplitsFromView to Money.setAmount()
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - * Check split not null in Listener onCheckedChanged
03225b1
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - ** Add shallDisplayZero in displayBalance(...) to av…
8f1767e 
…oid displaying 0
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - ** Add shallDisplayZero in displayBalanceWithoutCurr…
978a5eb 
…ency(...) to avoid displaying 0
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - Renaming toggleAmountInputEntryMode() to setAllowAmo…
b8d58a7 
…untEdit
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - Remove black color for 0 balance, to be homogeneous …
d92391b 
…with TransactionTypeSwitch.setWidgetTextColor()
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - Use updateAmountEditText(...) to factorize code
1f41df3
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 14, 2020
@JeanGarf
codinguser#876 - Code formatting
511f889
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 15, 2020
@JeanGarf
codinguser#876 - ** Must be on the Account Page to change Book
849bc2a
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 15, 2020
@JeanGarf
codinguser#876 - Code formatting
5d36c85
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 15, 2020
@JeanGarf
codinguser#876 - Remove codinguser#586
1e2d83a
John-Yu added a commit to John-Yu/gnucash-android that referenced this issue Jun 15, 2020
@John-Yu
* codinguser#876 - Fix NPE when type switching on a new transaction
7ec717d
John-Yu added a commit to John-Yu/gnucash-android that referenced this issue Jun 15, 2020
@John-Yu
* codinguser#876 - Fix NPE when type switching on a new transaction
f908b2e
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 16, 2020
@JeanGarf
codinguser#876 - Toast message internationalization
1ee83dd
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 16, 2020
@JeanGarf
codinguser#876 - Add another test to reduce probability of not being …
13b3baf 
…able to change Book
This was referenced Jun 19, 2020
Open
Closed
slak44 added a commit to slak44/gnucash-android that referenced this issue Sep 6, 2020
@slak44
Revert "codinguser#876 - hasDebitNormalBalance should not invert amou…
04fb088 
…nt signum"

This reverts commit 6615458.

# Conflicts:
#	app/src/main/java/org/gnucash/android/db/adapter/SplitsDbAdapter.java
slak44 added a commit to slak44/gnucash-android that referenced this issue Sep 6, 2020
@slak44
Revert "codinguser#876 - Logs and comments"
664a181 
This reverts commit 453252e.
JeanGarf added a commit to JeanGarf/gnucash-android that referenced this issue Jun 7, 2021
@JeanGarf
codinguser#876 - ** when editing transaction, display 2 decimals but …
8cca2e3 
…not currency symbol because it shall be evaluated (in order to allows arithmetic expressions as value)
Thumas added a commit to Thumas/gnucash-android that referenced this issue Jun 20, 2021
@Thumas
Corrected displayed money value in the split editor.
6e98dfa 
Commit c1a40f3 changed the way the money amount is displayed in the split editor. If you entered a decimal value in a split transaction, saved and then edited the split again, the values now seemed to be rounded and you would have to enter the correct values again to make changes.
-> Deleted toShortString method in Money and changed it to toLocaleString in AccountType.displayBalance().

codinguser#876
Thumas pushed a commit to Thumas/gnucash-android that referenced this issue Jun 20, 2021
@JeanGarf @Thumas
codinguser#876 - ** when editing transaction, display 2 decimals but …
2bd5da1 
…not currency symbol because it shall be evaluated (in order to allows arithmetic expressions as value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeanGarf