codinguser#876 - Enhance Code Quality

JeanGarf · Mar 6, 2020 · b31daad · b31daad
1 parent 52f59ef
commit b31daad
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/src/main/java/org/gnucash/android/db/adapter/SplitsDbAdapter.java b/app/src/main/java/org/gnucash/android/db/adapter/SplitsDbAdapter.java
@@ -220,13 +220,18 @@ private Money calculateSplitBalance(List<String> accountUIDList,
                            + " = 0";
 
         if (startTimestamp != -1 && endTimestamp != -1) {
+
             selection += " AND " + TransactionEntry.TABLE_NAME + "_" + TransactionEntry.COLUMN_TIMESTAMP + " BETWEEN ? AND ? ";
             selectionArgs = new String[]{String.valueOf(startTimestamp),
                                          String.valueOf(endTimestamp)};
+
         } else if (startTimestamp == -1 && endTimestamp != -1) {
+
             selection += " AND " + TransactionEntry.TABLE_NAME + "_" + TransactionEntry.COLUMN_TIMESTAMP + " <= ?";
             selectionArgs = new String[]{String.valueOf(endTimestamp)};
+
         } else if (startTimestamp != -1/* && endTimestamp == -1*/) {
+
             selection += " AND " + TransactionEntry.TABLE_NAME + "_" + TransactionEntry.COLUMN_TIMESTAMP + " >= ?";
             selectionArgs = new String[]{String.valueOf(startTimestamp)};
         }

diff --git a/app/src/main/java/org/gnucash/android/model/Money.java b/app/src/main/java/org/gnucash/android/model/Money.java
@@ -257,7 +257,8 @@ public double asDouble(){
 	public String asString(){
 		return toPlainString();
 	}
-
+
+	// TODO TW C 2020-03-06 : A factoriser avec Split.getFormattedAmount
 	/**
 	 * Returns a string representation of the Money object formatted according to 
 	 * the <code>locale</code> and includes the currency symbol.