Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-payload): serve target should detect file changes #225

Conversation

hakalb
Copy link
Member

@hakalb hakalb commented Nov 5, 2024

Also converted serve target to inferred

closed COD-147

@hakalb hakalb requested a review from lundinmathias November 5, 2024 12:54
@hakalb hakalb self-assigned this Nov 5, 2024
Copy link

stackblitz bot commented Nov 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

nx-cloud bot commented Nov 5, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18574a8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.34%. Comparing base (3dbc51a) to head (18574a8).

Files with missing lines Patch % Lines
...rc/migrations/update-0.11.1/remove-serve-target.ts 90.90% 3 Missing ⚠️
...ages/nx-payload/src/utils/has-nx-payload-plugin.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   97.54%   96.34%   -1.21%     
==========================================
  Files          17       19       +2     
  Lines         204      246      +42     
  Branches       29       41      +12     
==========================================
+ Hits          199      237      +38     
- Misses          5        9       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also converted serve target to inferred

closed COD-147
@hakalb hakalb force-pushed the cod-147-running-serve-for-nx-payload-doesnt-detect-file-changes branch from 68327fe to 18574a8 Compare November 5, 2024 12:57
@hakalb hakalb added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit d416850 Nov 5, 2024
13 checks passed
@hakalb hakalb deleted the cod-147-running-serve-for-nx-payload-doesnt-detect-file-changes branch November 5, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants