Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double wildcard paths like collection** on change events (missing return value) #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

treet
Copy link

@treet treet commented Jan 24, 2014

I can't get hooks like store.allow('change', 'collection**') or store.allow('change', 'collection.**') to work, any validations added on such paths will never trigger. store.allow('all', 'collection**') still triggers fine, which I think has to do with _allow_all checking manually for those kind of paths. Are these patterns not available for change events? Is the missing return value a bug or was it intended?

How can I capture all changes under a specific collection?

(Edit: I just realised these changes are wrong, relativePath should perhaps return something like [null].concat(relativeSegments)?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant