Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patchwork PR for Updating SDK Docs with Claude #14

Open
wants to merge 20 commits into
base: claude-only-index-run
Choose a base branch
from

Conversation

codelion
Copy link
Owner

@codelion codelion commented Aug 20, 2024

This pull request from patchwork updates 20 SDK Docs


@codelion codelion force-pushed the patchwork-claude-only-index-run branch from 25adbaa to 9ec2e53 Compare August 20, 2024 06:23
patched.codes[bot] added 20 commits August 19, 2024 23:33
@codelion codelion force-pushed the patchwork-claude-only-index-run branch from 9ec2e53 to a43cbea Compare August 20, 2024 06:33
Copy link

@N2D4 N2D4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good already, but can it do the StackClientApp, StackServerApp, and StackAdminApp classes yet?


## Parameters

- `props`: `SelectedTeamSwitcherProps` - An object containing the following properties:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This props should not be added

import { useUser } from "@stackframe/stack";
- `options` (optional): `GetUserOptions` - Options for retrieving user information.
- `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated.
- `projectIdMustMatch` (optional): `'internal'` - Ensures the user belongs to an internal project.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is incorrect, it should be string, not 'internal'. This type is incorrect, it should be 'redirect' | 'throw' | 'return-null' (where the third is the default). I believe the AI got confused by the many overloads of this function

```jsx
import { useUser } from "@stackframe/stack";
- `options` (optional): `GetUserOptions` - Options for retrieving user information.
- `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type is incorrect, it should be 'redirect' | 'throw' | 'return-null' (where the third is the default). I believe the AI got confused by the many overloads of this function


## Parameters

- `props`: `UserButtonProps` - Properties for configuring the UserButton component.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should show the properties of UserButtonProps instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants