-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patchwork PR for Updating SDK Docs with Claude #14
base: claude-only-index-run
Are you sure you want to change the base?
Conversation
25adbaa
to
9ec2e53
Compare
…dk/selected-team-switcher.mdx
…dk/password-reset.mdx
…dk/magic-link-sign-in.mdx
…dk/stack-theme.mdx
…dk/stack-handler.mdx
…dk/forgot-password.mdx
…dk/account-settings.mdx
…dk/email-verification.mdx
…dk/credential-sign-in.mdx
…dk/oauth-button-group.mdx
…dk/oauth-button.mdx
…dk/stack-provider.mdx
…dk/credential-sign-up.mdx
…dk/use-stack-app.mdx
…dk/message-card.mdx
…dk/user-button.mdx
9ec2e53
to
a43cbea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good already, but can it do the StackClientApp, StackServerApp, and StackAdminApp classes yet?
|
||
## Parameters | ||
|
||
- `props`: `SelectedTeamSwitcherProps` - An object containing the following properties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This props
should not be added
import { useUser } from "@stackframe/stack"; | ||
- `options` (optional): `GetUserOptions` - Options for retrieving user information. | ||
- `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated. | ||
- `projectIdMustMatch` (optional): `'internal'` - Ensures the user belongs to an internal project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type is incorrect, it should be string
, not 'internal'
. This type is incorrect, it should be 'redirect' | 'throw' | 'return-null'
(where the third is the default). I believe the AI got confused by the many overloads of this function
```jsx | ||
import { useUser } from "@stackframe/stack"; | ||
- `options` (optional): `GetUserOptions` - Options for retrieving user information. | ||
- `or` (optional): `'redirect' | 'throw'` - Specifies behavior if user is not authenticated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type is incorrect, it should be 'redirect' | 'throw' | 'return-null'
(where the third is the default). I believe the AI got confused by the many overloads of this function
|
||
## Parameters | ||
|
||
- `props`: `UserButtonProps` - Properties for configuring the UserButton component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should show the properties of UserButtonProps instead
This pull request from patchwork updates 20 SDK Docs