Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UserModel::createNewUser() and RegisterController uses it #1196

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: add UserModel::createNewUser() and RegisterController uses it #1196

wants to merge 8 commits into from

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 8, 2024 •
edited
Loading

Description
Supersedes #1172

  • add UserModel::createNewUser()
  • refactor

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the enhancement New feature or request label Sep 8, 2024
@kenjis kenjis force-pushed the add-UserModel-createNewUser branch from 5002391 to 729af3a Compare September 8, 2024 03:03
@kenjis kenjis force-pushed the add-UserModel-createNewUser branch from 729af3a to 9bf9e7d Compare September 8, 2024 03:05
@kenjis kenjis mentioned this pull request Sep 8, 2024
Closed
5 tasks
datamweb
datamweb approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianberkman christianberkman christianberkman approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @christianberkman