Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for every database handler #49

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Add tests for every database handler #49

wants to merge 11 commits into from

Conversation

michalsn
Copy link
Member

Description
This PR adds tests for all database handlers.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn
Copy link
Member Author

Okay, seems like I will have to set up a local docker image to resolve this.

@michalsn michalsn requested a review from kenjis September 20, 2024 18:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10964216839

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 90.179%
Totals Coverage Status
Change from base Build 10938598555: 2.7%
Covered Lines: 505
Relevant Lines: 560
💛 - Coveralls

@michalsn michalsn mentioned this pull request Sep 23, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis Awaiting requested review from kenjis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsn @coveralls