Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change namespace #10

Merged
merged 8 commits into from
Dec 17, 2023
Merged

Change namespace #10

merged 8 commits into from
Dec 17, 2023

Conversation

michalsn
Copy link
Member

Description
Change the namespace and all related info to the codeigniter.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked at it in detail, but the tests passed.

@kenjis kenjis mentioned this pull request Dec 16, 2023
Merged
5 tasks
@michalsn
Copy link
Member Author

Thanks for the review. I guess we will have to wait until some basic permissions for members are set to merge.

@lonnieezell lonnieezell merged commit 6b9699c into codeigniter4:develop Dec 17, 2023
11 checks passed
@michalsn michalsn deleted the namespace branch December 17, 2023 19:12
@MGatner
Copy link
Member

MGatner commented Dec 19, 2023

I'm late to the game here: are you missing merge permissions on this repo?

@michalsn
Copy link
Member Author

No, everything is fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalsn @MGatner @lonnieezell @kenjis