-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade to use phpstan 2 and rector 2 #9322
refactor: upgrade to use phpstan 2 and rector 2 #9322
Conversation
/cc @ddevsr |
phpstan-codeigniter seems stil require phpstan v1, so in there should be updated first:
|
Ok, bump to use phpstan-codeigniter 1.5.1 is the way 9b6d9bf |
install seems got codeigniter ^4.5 conflict notice:
ref https://github.com/codeigniter4/CodeIgniter4/actions/runs/12333325314/job/34422197398?pr=9322 @paulbalandan @kenjis any idea? |
@samsonasik that should be taken care of in #9299, i just need to get @kenjis ' approval |
@samsonasik pls rebase in latest develop. probably you would just need to update rector version |
9b6d9bf
to
1147411
Compare
Rebased 👍 |
Setup PHP error seems unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go. I'm merging this.
Description
This PR upgrade to use PHPStan 2 and Rector 2.
Checklist: