feat: Improve for windows #9318
Conversation
|
@datamweb We are waiting for an opinion |
| @@ -0,0 +1,202 @@ | |||
| 15) CodeIgniter\Files\FileCollectionTest::testResolveDirectorySymlink | |||
| ErrorException: symlink(): Permission denied | |||
There was a problem hiding this comment.
To bypass the issue related to Permission denied rights, you can run your terminal with "Run as Administrator" privileges.
There was a problem hiding this comment.
You can skip the test when in windows by adding a @requires OS Linux phpdoc
There was a problem hiding this comment.
It is undesirable to skip it. More useful to show a notification of admin rights.
There was a problem hiding this comment.
Yes, but how for Github actions?
There was a problem hiding this comment.
There are no actions under windows right now. The tests are completed. You can check is_windows() and show a warning. Or describe this case in the documentation
| E:\www\CodeIgniterProjects\dev\tests\system\Helpers\FilesystemHelperTest.php:525 | ||
|
|
||
| 20) CodeIgniter\Publisher\PublisherInputTest::testAddUri | ||
| CodeIgniter\HTTP\Exceptions\HTTPException: 60 : SSL certificate problem: unable to get local issuer certificate |
There was a problem hiding this comment.
It seems that this issue is related to an incorrect configuration on your system. I do not have this problem. Please try to resolve it by referring to the link below:
There was a problem hiding this comment.
Ok. I used to disable validation in other scripts. I didn't get an error. If the PR is approved, it will be described in the documentation
|
It is important to consider the fix globally. Is it good to use the new functions? |
| <!-- Directory containing the front controller (index.php) --> | ||
| <const name="PUBLICPATH" value="./public/"/> | ||
| </php> | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
There was a problem hiding this comment.
what changed here? line indents?
There was a problem hiding this comment.
Yes. Enable showing deprecations in console - autoreformat file.
| /** | ||
| * A real path with identical slashes in Unix/Windows | ||
| */ | ||
| function _realpath(string $path): bool|string |
There was a problem hiding this comment.
I would put this inside your normalize_path function.
There was a problem hiding this comment.
Maybe. But they are created in different areas. The problem now is duplicates - they are needed in the earliest call. normalize_path() is available later
There was a problem hiding this comment.
Oh, these are slightly different functions. normalize_path() can take a nonexistent or relative path. Why add realpath() to it?
neznaika0
force-pushed
the
improve-for-windows
branch
4 times, most recently
from
6c9f82e to
fe72702
Compare
Signed-off-by: neznaika0 <[email protected]>
Signed-off-by: neznaika0 <[email protected]>
neznaika0
force-pushed
the
improve-for-windows
branch
from
fe72702 to
ea9be93
Compare
Description
See https://forum.codeigniter.com/showthread.php?tid=92138
An attempt to adapt to the Windows system. This PR is not for merging, it is for viewing. I ask you to speak about the method. File ./errors.txt the errors that remained in my system. For those who do not have windows.
Maybe I want too much, but we don't have enough discussion to resolve such issues.
Checklist: