Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename controller to Controller #9314

Merged

Conversation

paulbalandan
Copy link
Member

Description
Last errors for class.nameCase

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Dec 11, 2024
@samsonasik
Copy link
Member

it seems cause test error:

1) CodeIgniter\Router\RouteCollectionTest::testAddRecognizesCustomNamespaces
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 [
-    'home' => '\CodeIgniter\Controller',
+    'home' => '\CodeIgniter\controller',
 ]

@michalsn
Copy link
Member

Always sand in the eyes 😢

@paulbalandan paulbalandan force-pushed the rename-controller-to-Controller branch from 609379e to 562ddf2 Compare December 11, 2024 16:21
@samsonasik samsonasik merged commit 0b0126c into codeigniter4:develop Dec 11, 2024
39 checks passed
@samsonasik
Copy link
Member

Thank you @paulbalandan

@paulbalandan paulbalandan deleted the rename-controller-to-Controller branch December 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants