-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable code quality level 34 for rector #9311
base: 4.6
Are you sure you want to change the base?
refactor: enable code quality level 34 for rector #9311
Conversation
Ready for review 👍 , while doesn't change native type, this can goes to 4.6 branch if needed since it change docblock returns from allowed union void to nullable union and may cause phpstan notice on user that override it. |
In |
On child classes, more specific returns is ok, the parent interface allow |
Why are we now returning |
dcf235e
to
6538738
Compare
Response return in system/CodeIgniter.php and other places: $possibleResponse = $this->runRequiredBeforeFilters($filters); |
Description
Applied
ExplicitReturnNullRector
to add explicit return null to method/function that returns a value, but missed main return.void in union should not happen.
Checklist: