Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exceptions for non-HTML responses #9308

Closed

Conversation

michalsn
Copy link
Member

@michalsn michalsn commented Dec 9, 2024

Description
This PR fixes a bug where exceptions for non-HTML responses did not rely on the display_errors setting.

Fixes: #9242

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Dec 9, 2024
@kenjis
Copy link
Member

kenjis commented Dec 9, 2024

Is there any possibility of unexpected errors being displayed?

@michalsn
Copy link
Member Author

michalsn commented Dec 9, 2024

Is there any possibility of unexpected errors being displayed?

I don't believe so. The display_errors is set per environment in app/Config/Boot/, so from this point of view, nothing has changed. However, this will enable adjusting settings for any other environment, like staging etc., when added.

@kenjis
Copy link
Member

kenjis commented Dec 9, 2024

@michalsn
Okay, the risk seems very very low.

@neznaika0
Copy link
Contributor

Heh, already there in the next branch

private function isDisplayErrorsEnabled(): bool

@michalsn
Copy link
Member Author

LOL... thanks

@michalsn michalsn closed this Dec 10, 2024
@neznaika0
Copy link
Contributor

@michalsn no no, It is worth updating the changelog. This fix is not specified in 4.6

@michalsn
Copy link
Member Author

@neznaika0 I sent a separate PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Environments
4 participants