Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: full support on PHP8.4 #9255

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat: full support on PHP8.4 #9255

merged 5 commits into from
Dec 17, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Nov 5, 2024 •
edited
Loading

Description
Review without ignore-platform-php, Reference to #9116 latest checklist.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr changed the title refactor: review github CI on PHP8.4 refactor: review github CI on PHP8.4 Nov 5, 2024
@neznaika0
Copy link
Contributor

php-cs-fixer:

Note Each new PHP version requires a huge effort to support the new syntax. That's why the latest PHP version might not be supported yet. If you need it, please, consider supporting the project in any convenient way, for example with code contribution or reviewing existing PRs. To run PHP CS Fixer on yet unsupported versions "at your own risk" - leverage the PHP_CS_FIXER_IGNORE_ENV.

@ddevsr ddevsr added github_actions Pull requests that update Github_actions code 4.6 labels Nov 6, 2024
@ddevsr
Copy link
Collaborator Author

ddevsr commented Nov 8, 2024

FakerPHP/Faker already merge, release soon on v1.24.

@github-actions github-actions bot added the stale Pull requests with conflicts label Nov 21, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@ddevsr ddevsr removed the stale Pull requests with conflicts label Nov 21, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@ddevsr ddevsr removed the stale Pull requests with conflicts label Dec 2, 2024
@ddevsr ddevsr changed the title refactor: review github CI on PHP8.4 feat: full support on PHP8.4 Dec 3, 2024
@ddevsr
Copy link
Collaborator Author

ddevsr commented Dec 3, 2024

Last dependencies vimeo/psalm will be release v6 in this week

@paulbalandan
Copy link
Member

How about for php-cs-fixer?

@ddevsr
Copy link
Collaborator Author

ddevsr commented Dec 3, 2024

@paulbalandan Added test again with PHP_CS_FIXER_IGNORE_ENV, running smooth

paulbalandan
paulbalandan reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the PHP_CS_FIXER_IGNORE_ENV flag to the CS github actions YML file instead of in composer.json. This way the flag is only added when PHP is 8.4

michalsn
michalsn reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for stepping in and taking care of it.

Although I don't think we'll wait for php-cs-fixer to be released - current support is sufficient.

@ddevsr ddevsr marked this pull request as ready for review December 16, 2024 10:32
@ddevsr
Copy link
Collaborator Author

ddevsr commented Dec 16, 2024

@michalsn @paulbalandan Lets merge?

@paulbalandan
Copy link
Member

Are there no more blocking deps?

@ddevsr
Copy link
Collaborator Author

ddevsr commented Dec 16, 2024

Composer ignore-platform-req in utils for Psalm only. PHP-CS-Fixer just waiting full support, but in this project no issue

@paulbalandan
Copy link
Member

Ok, our build seems passing so this can be merged.

@michalsn michalsn merged commit cd5dda1 into codeigniter4:4.6 Dec 17, 2024
48 checks passed
@michalsn
Copy link
Member

Thank you @ddevsr!

@ddevsr ddevsr deleted the review-php84 branch December 17, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

@kenjis kenjis Awaiting requested review from kenjis

Assignees
No one assigned
Labels
4.6 github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddevsr @neznaika0 @paulbalandan @michalsn