Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional opcache setting in check php.ini #9032

Open
wants to merge 14 commits into
base: 4.6
Choose a base branch
from
Prev Previous commit
Next Next commit
fix: errors on GA
ddevsr committed Aug 22, 2024
commit 36698fcc4769d2e95260be9840a93346c6f38e3d
2 changes: 1 addition & 1 deletion system/Commands/Utilities/PhpIniCheck.php
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ public function run(array $params)
return EXIT_ERROR;
}

$argument = isset($params[0]) && $params[0] ? $params[0] : null;
$argument = $params[0] ?? null;

CheckPhpIni::run(argument: $argument);

5 changes: 2 additions & 3 deletions tests/system/Commands/Utilities/PhpIniCheckTest.php
Original file line number Diff line number Diff line change
@@ -15,7 +15,6 @@

use CodeIgniter\Test\CIUnitTestCase;
use CodeIgniter\Test\StreamFilterTrait;
use Config\App;
use PHPUnit\Framework\Attributes\Group;

/**
@@ -38,7 +37,7 @@ protected function tearDown(): void
parent::tearDown();
}

protected function getBuffer()
protected function getBuffer(): string
{
return $this->getStreamFilterBuffer();
}
@@ -60,7 +59,7 @@ public function testCommandCheckOpcache(): void
{
command('phpini:check opcache');

$this->assertStringContainsString("opcache.save_comments", $this->getBuffer());
$this->assertStringContainsString('opcache.save_comments', $this->getBuffer());
}

public function testCommandCheckNoExistsArg(): void
Loading