Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix PHPStan in Commands #8964

Merged
merged 4 commits into from
Jun 19, 2024
Merged

docs: fix PHPStan in Commands #8964

merged 4 commits into from
Jun 19, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Jun 14, 2024

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr added the documentation Pull requests for documentation only label Jun 14, 2024
@kenjis
Copy link
Member

kenjis commented Jun 15, 2024

@ddevsr
I use the label documentation to PRs to change the User Guide.
Do you think it is better to use the label to the PR to doc comments like this?

@github-actions github-actions bot added the stale Pull requests with conflicts label Jun 19, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @ddevsr!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@ddevsr ddevsr force-pushed the phpstan-commands branch from 801c7b3 to c2e843f Compare June 19, 2024 10:29
@ddevsr ddevsr removed the stale Pull requests with conflicts label Jun 19, 2024
@ddevsr ddevsr requested a review from kenjis June 19, 2024 10:34
@kenjis kenjis merged commit c8b8995 into codeigniter4:develop Jun 19, 2024
41 checks passed
@kenjis
Copy link
Member

kenjis commented Jun 19, 2024

@ddevsr Thank you!

@kenjis kenjis removed the documentation Pull requests for documentation only label Jun 20, 2024
@ddevsr ddevsr deleted the phpstan-commands branch June 20, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @kenjis @datamweb