fix: Forge::dropColumn() seems to always return false.

phpstan-baseline.php

@@ -2677,12 +2677,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Database/Forge.php',
 ];
-$ignoreErrors[] = [
-	// identifier: missingType.iterableValue
-	'message' => '#^Method CodeIgniter\\\\Database\\\\Forge\\:\\:dropColumn\\(\\) has parameter \\$columnNames with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Database/Forge.php',
-];
 $ignoreErrors[] = [
 	// identifier: missingType.iterableValue
 	'message' => '#^Method CodeIgniter\\\\Database\\\\Forge\\:\\:modifyColumn\\(\\) has parameter \\$fields with no value type specified in iterable type array\\.$#',

system/Database/Forge.php

@@ -778,7 +778,7 @@ public function addColumn(string $table, $fields): bool
     }
 
     /**
-     * @param array|string $columnNames column names to DROP
+     * @param list<string>|string $columnNames column names to DROP
      *
      * @return bool
      *

system/Database/SQLite3/Forge.php

@@ -121,17 +121,6 @@ public function dropDatabase(string $dbName): bool
     protected function _alterTable(string $alterType, string $table, $processedFields)
     {
         switch ($alterType) {
-            case 'DROP':
-                $columnNamesToDrop = $processedFields;
-
-                $sqlTable = new Table($this->db, $this);
-
-                $sqlTable->fromTable($table)
-                    ->dropColumn($columnNamesToDrop)
-                    ->run();
-
-                return ''; // Why empty string?
-
             case 'CHANGE':
                 $fieldsToModify = [];
 
@@ -164,6 +153,32 @@ protected function _alterTable(string $alterType, string $table, $processedField
         }
     }
 
+    /**
+     * @param list<string>|string $columnNames column names to DROP
+     *
+     * @return bool
+     *
+     * @throws DatabaseException
+     */
+    public function dropColumn(string $table, $columnNames)
+    {
+        $sqlTable = new Table($this->db, $this);
+
+        $sqlExecuteResult = $sqlTable->fromTable($this->db->DBPrefix . $table)
+            ->dropColumn($columnNames)
+            ->run();
+
+        if ($sqlExecuteResult === false) {
+            if ($this->db->DBDebug) {
+                throw new DatabaseException('This feature is not available for the database you are using.');
+            }
+
+            return false;
+        }
+
+        return $sqlExecuteResult;
+    }
+
     /**
      * Process column
      */

tests/system/Database/Live/ForgeTest.php

@@ -488,7 +488,7 @@
         $this->forge->dropTable('', true);
     }
 
     public function testForeignKey(): void
     {
         $this->forge->dropTable('forge_test_invoices', true);
         $this->forge->dropTable('forge_test_users', true);
@@ -1230,7 +1230,7 @@
         $this->forge->dropTable('forge_test_1', true);
     }
 
     public function testSetKeyNames(): void
     {
         $this->forge->dropTable('forge_test_1', true);
 
@@ -1317,7 +1317,8 @@
 
         $this->assertTrue($this->db->fieldExists('name', 'forge_test_two'));
 
-        $this->forge->dropColumn('forge_test_two', 'name');
+        $result = $this->forge->dropColumn('forge_test_two', 'name');
+        $this->assertTrue($result);
 
         $this->db->resetDataCache();
 
@@ -1665,7 +1666,7 @@
         $this->forge->dropTable('forge_test_users', true);
     }
 
     public function testProcessIndexes(): void
     {
         // make sure tables don't exist
         $this->forge->dropTable('actions', true);