Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix @param BaseBuilder.php #8808

Merged
merged 5 commits into from
Apr 26, 2024
Merged

docs: fix @param BaseBuilder.php #8808

merged 5 commits into from
Apr 26, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Apr 19, 2024 •
edited
Loading

Description
See https://github.com/codeigniter4/CodeIgniter4/actions/runs/8748888596/job/24009622239
Related #8732

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

samsonasik
samsonasik requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan baseline need to be regenerated

@ddevsr ddevsr marked this pull request as draft April 19, 2024 10:43
@ddevsr ddevsr marked this pull request as ready for review April 22, 2024 03:01
@ddevsr ddevsr requested review from kenjis and samsonasik April 22, 2024 03:01
@kenjis kenjis changed the title docs: @param BaseBuilder.php docs: fix @param BaseBuilder.php Apr 23, 2024
@kenjis kenjis merged commit 747108f into codeigniter4:develop Apr 26, 2024
40 checks passed
@ddevsr ddevsr deleted the patch-3 branch April 26, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@samsonasik samsonasik Awaiting requested review from samsonasik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @kenjis @samsonasik