Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: system/Debug/Toolbar/Collectors/Routes.php #8751

Merged
merged 2 commits into from
Apr 12, 2024
Merged

refactor: system/Debug/Toolbar/Collectors/Routes.php #8751

merged 2 commits into from
Apr 12, 2024

Conversation

mcsaygili
Copy link
Contributor

@mcsaygili mcsaygili commented Apr 10, 2024 •
edited
Loading

Description
See #8732

  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 10, 2024
@mcsaygili mcsaygili force-pushed the refactor-system-Debug-Toolbar-Collectors-Routes.php branch from 4fa96ba to fd782e7 Compare April 12, 2024 14:52
kenjis
kenjis approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis merged commit fb9607c into codeigniter4:develop Apr 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcsaygili @kenjis @michalsn