Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add return void #8746

Merged
merged 3 commits into from
Apr 10, 2024
Merged

test: add return void #8746

merged 3 commits into from
Apr 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 10, 2024 •
edited
Loading

Description
See #7731

  • add return void to test files
  • add config for php-cs-fixer for tests files

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the testing Pull requests that changes tests only label Apr 10, 2024
@kenjis kenjis merged commit 2ae1930 into codeigniter4:develop Apr 10, 2024
39 checks passed
@kenjis kenjis deleted the test-add-return-void branch April 10, 2024 23:12
@kenjis kenjis added the refactor Pull requests that refactor code label Apr 12, 2024
@kenjis kenjis mentioned this pull request May 6, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @paulbalandan