Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: restore goals.rst from 3.0 user guide #8557

Merged
merged 1 commit into from
Jun 12, 2024
Merged

docs: restore goals.rst from 3.0 user guide #8557

merged 1 commit into from
Jun 12, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Feb 18, 2024

Description
I don't know why this "Design and Architectural Goals" was removed in 4.0 user guide.
But I would like to restore it.

Basically, this goal is still valid today. If there are any changes that should be made,
please comment.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Feb 18, 2024
TimexPeachtree
TimexPeachtree approved these changes Feb 18, 2024
View reviewed changes
Copy link

@TimexPeachtree TimexPeachtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess this looks back to good

@kenjis
Copy link
Member Author

kenjis commented Mar 5, 2024

Related #8201

neznaika0
neznaika0 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is not critical, but has been hanging in PR for a long time

@kenjis
Copy link
Member Author

kenjis commented Jun 7, 2024

@MGatner @lonnieezell May I merge this?

MGatner
MGatner approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this. I came in for a critical read and found no real issues - which makes me think this document might be too abstract or general.

@kenjis kenjis merged commit cf0e87d into codeigniter4:develop Jun 12, 2024
3 checks passed
@kenjis kenjis deleted the docs-concepts-goals.rst branch June 12, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

@TimexPeachtree TimexPeachtree TimexPeachtree approved these changes

@MGatner MGatner MGatner approved these changes

@neznaika0 neznaika0 neznaika0 approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kenjis @datamweb @neznaika0 @MGatner @TimexPeachtree @paulbalandan @ddevsr