Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add Closure signature for CodeIgniter::$controller #8107

Merged
merged 1 commit into from
Oct 28, 2023
Merged

docs: add Closure signature for CodeIgniter::$controller #8107

merged 1 commit into from
Oct 28, 2023

Conversation

paulbalandan
Copy link
Member

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title fix: add Closure signature for CodeIgniter::$controller docs: add Closure signature for CodeIgniter::$controller Oct 27, 2023
michalsn
michalsn approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some signatures are starting to look scary to me 😜

@kenjis kenjis merged commit 244dad6 into codeigniter4:develop Oct 28, 2023
57 of 60 checks passed
@paulbalandan paulbalandan deleted the phpstan-codeigniter-controller branch October 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @michalsn