-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Repair conflicts and emove the Debug
ignore errors.
#7801
Fix: Repair conflicts and emove the Debug
ignore errors.
#7801
Conversation
Debug
ignore errors.
system/Debug/Exceptions.php
Outdated
@@ -98,6 +98,9 @@ public function __construct(ExceptionsConfig $config, $request, ResponseInterfac | |||
* handling of our application. | |||
* | |||
* @codeCoverageIgnore | |||
* | |||
* @return void | |||
* @phpstan-return never|void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems never
is not returned. See https://phpstan.org/writing-php-code/phpdoc-types#bottom-type
* @phpstan-return never|void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed there to @phpstan-return void
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If @return
and @phpstan-return
are the same, @phpstan-return
is not needed.
Remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
system/Debug/Toolbar.php
Outdated
@@ -348,6 +348,9 @@ protected function roundTo(float $number, int $increments = 5): float | |||
* | |||
* @param RequestInterface $request | |||
* @param ResponseInterface $response | |||
* | |||
* @return void | |||
* @phpstan-return never|void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any exit()
or die()
in this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There does not include exit() or die().
So, I changed there to @phpstan-return void
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
See #7731
Sorry, There was a conflict with a previous modification (#7796) and due to my operational issues I have reorganized the complete modification into a new PR.
Checklist: