Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Remove the ignore errors of Encryption and Entity in phpstan. #7783

Merged

Conversation

ya861220
Copy link
Contributor

@ya861220 ya861220 commented Aug 5, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

system/Entity/Entity.php Outdated Show resolved Hide resolved
@kenjis
Copy link
Member

kenjis commented Aug 7, 2023

By the way, what do you mean by dev: in the commit messages? > @ya861220 @ping-yee @kai890707

See https://www.conventionalcommits.org/en/v1.0.0/
https://gist.github.com/joshbuchea/6f47e86d2510bce28f8e7f42ae84c716

@ping-yee
Copy link
Contributor

ping-yee commented Aug 8, 2023

It's our misunderstanding and we will follow the semantics commit message in the future commits.
Appreciate it! @kenjis

@paulbalandan paulbalandan merged commit c640145 into codeigniter4:develop Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants