Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Remove the Honeypot and I18n ignore errors in phpstan-baseline.php #7770

Merged
merged 7 commits into from
Aug 8, 2023
Merged

Dev: Remove the Honeypot and I18n ignore errors in phpstan-baseline.php #7770

merged 7 commits into from
Aug 8, 2023

Conversation

ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Aug 3, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis
kenjis approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis added the stale Pull requests with conflicts label Aug 6, 2023
@kenjis
Copy link
Member

kenjis commented Aug 6, 2023

Please rebase to resolve conflict.

@ping-yee ping-yee force-pushed the 230804-phpstan-honeypot-i18n branch from 0436792 to 25248a5 Compare August 7, 2023 10:28
@ddevsr ddevsr removed the stale Pull requests with conflicts label Aug 8, 2023
@ddevsr ddevsr mentioned this pull request Aug 8, 2023
Closed
5 tasks
@kenjis kenjis merged commit e0a1094 into codeigniter4:develop Aug 8, 2023
@kenjis
Copy link
Member

kenjis commented Aug 8, 2023

@ping-yee Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ping-yee @kenjis @datamweb @ddevsr