Dev: Remove the image ignore errors in phpstan-baseline.php

[ping-yee]

Description
See #7731

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[paulbalandan]

Sorry, can you make this as PHPDoc instead? I mistakenly written yesterday in your earlier PR that it is protected so we can add the : void directly. I meant it is final. With your change it will violate LSP for those people extending the methods.

Please revise the same with the other protected methods.

[ping-yee]

Should the image exception return type also be written in the comments?

[MGatner]

I'm in favor of leaving the exception return types in place. Framework exceptions are explicitly for framework code - so even though they aren't marked @internal they still should not be extended - and certainly not their names constructors.

[paulbalandan]

@MGatner then I think we should instead use new self over new static

[kenjis]

@MGatner @paulbalandan

Framework exceptions are explicitly for framework code - so even though they aren't marked @internal they still should not be extended

It is not documented, and I did not know that.
In fact, we could extend these exceptions.

So I oppose this breaking change. It is better to add @internal or final in 4.4 branch, and add return type.

[kenjis]

I think patch versions should not change the signatures of extensible methods.

[MGatner]

Thanks @ping-yee for this ongoing effort!