Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Remove the config ignore errors. #7764

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

ping-yee
Copy link
Contributor

@ping-yee ping-yee commented Aug 2, 2023

Description
See #7731

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

system/Config/ForeignCharacters.php Outdated Show resolved Hide resolved
system/Config/Publisher.php Outdated Show resolved Hide resolved
system/Config/View.php Outdated Show resolved Hide resolved
system/Config/View.php Show resolved Hide resolved
system/Config/View.php Outdated Show resolved Hide resolved
system/Config/ForeignCharacters.php Outdated Show resolved Hide resolved
@MGatner
Copy link
Member

MGatner commented Aug 3, 2023

Paul's review looks thorough - skipping but let me know if you need me.

@kenjis kenjis merged commit 892f404 into codeigniter4:develop Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants