Merge pull request #7746 from paulbalandan/types-autoloader

Add types to Autoloader
codeigniter4 · Jul 29, 2023 · fbdcee4 · fbdcee4
2 parents 621edbe + 68a0907
commit fbdcee4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -1,16 +1,6 @@
 <?php declare(strict_types = 1);
 
 $ignoreErrors = [];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Autoloader\\\\Autoloader\\:\\:discoverComposerNamespaces\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Autoloader/Autoloader.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\Autoloader\\\\Autoloader\\:\\:register\\(\\) has no return type specified\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Autoloader/Autoloader.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Parameter \\#1 \\$callback of function spl_autoload_register expects \\(callable\\(string\\)\\: void\\)\\|null, array\\{\\$this\\(CodeIgniter\\\\Autoloader\\\\Autoloader\\), \'loadClass\'\\} given\\.$#',
 	'count' => 1,

diff --git a/system/Autoloader/Autoloader.php b/system/Autoloader/Autoloader.php
@@ -148,6 +148,8 @@ private function loadComposerInfo(Modules $modules): void
 
     /**
      * Register the loader with the SPL autoloader stack.
+     *
+     * @return void
      */
     public function register()
     {
@@ -445,6 +447,8 @@ private function loadComposerClassmap(ClassLoader $composer): void
      * Locates autoload information from Composer, if available.
      *
      * @deprecated No longer used.
+     *
+     * @return void
      */
     protected function discoverComposerNamespaces()
     {