Merge pull request #8742 from mcsaygili/refactor-system-View-Plugins.php

refactor: system/View/Plugins.php
codeigniter4 · Apr 12, 2024 · 22e3450 · 22e3450
2 parents ea7c719 + 7034868
commit 22e3450
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 30 deletions.
diff --git a/phpstan-baseline.php b/phpstan-baseline.php
@@ -9726,36 +9726,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/View/Parser.php',
 ];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:ValidationErrors\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:lang\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:mailto\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:route\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:safeMailto\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
-$ignoreErrors[] = [
-	'message' => '#^Method CodeIgniter\\\\View\\\\Plugins\\:\\:siteURL\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/View/Plugins.php',
-];
 $ignoreErrors[] = [
 	'message' => '#^Method CodeIgniter\\\\View\\\\RendererInterface\\:\\:render\\(\\) has parameter \\$options with no value type specified in iterable type array\\.$#',
 	'count' => 1,

diff --git a/system/View/Plugins.php b/system/View/Plugins.php
@@ -42,6 +42,8 @@ public static function previousURL()
 
     /**
      * Wrap helper function to use as view plugin.
+     *
+     * @param array{email?: string, title?: string, attributes?: array<string, string>|object|string} $params
      */
     public static function mailto(array $params = []): string
     {
@@ -54,6 +56,8 @@ public static function mailto(array $params = []): string
 
     /**
      * Wrap helper function to use as view plugin.
+     *
+     * @param array{email?: string, title?: string, attributes?: array<string, string>|object|string} $params
      */
     public static function safeMailto(array $params = []): string
     {
@@ -66,6 +70,8 @@ public static function safeMailto(array $params = []): string
 
     /**
      * Wrap helper function to use as view plugin.
+     *
+     * @param array<int|string, string>|list<string> $params
      */
     public static function lang(array $params = []): string
     {
@@ -76,6 +82,8 @@ public static function lang(array $params = []): string
 
     /**
      * Wrap helper function to use as view plugin.
+     *
+     * @param array{field?: string} $params
      */
     public static function ValidationErrors(array $params = []): string
     {
@@ -90,6 +98,8 @@ public static function ValidationErrors(array $params = []): string
     /**
      * Wrap helper function to use as view plugin.
      *
+     * @param list<string> $params
+     *
      * @return false|string
      */
     public static function route(array $params = [])
@@ -99,6 +109,8 @@ public static function route(array $params = [])
 
     /**
      * Wrap helper function to use as view plugin.
+     *
+     * @param list<string> $params
      */
     public static function siteURL(array $params = []): string
     {