Fix notifier without any layout

[Swatinem]

This accounts for the case when settings does not have any "layout".

Also cleans up the code a little bit, using newer type annotations, and removing statsd timers.

---

Should fix ECDN-WORKER-D7G
fixes https://github.com/codecov/internal-issues/issues/974

[codecov-notifications]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../notification/notifiers/mixins/message/__init__.py	96.29%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         442      441       -1     
  Lines       36163    36048     -115     
==========================================
- Hits        35448    35333     -115     
  Misses        715      715              

Flag	Coverage Δ
integration	98.01% <96.29%> (-0.01%)	⬇️
unit	98.01% <96.29%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.89% <96.29%> (-0.02%)	⬇️
OutsideTasks	98.00% <96.29%> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
.../notification/notifiers/mixins/message/__init__.py	99.07% <96.29%> (-0.93%)	⬇️

... and 55 files with indirect coverage changes

[codecov-qa]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.01%. Comparing base (79f57df) to head (c1f99d8).
Report is 67 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../notification/notifiers/mixins/message/__init__.py	96.29%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         442      441       -1     
  Lines       36163    36048     -115     
==========================================
- Hits        35448    35333     -115     
  Misses        715      715              

Flag	Coverage Δ
integration	98.01% <96.29%> (-0.01%)	⬇️
unit	98.01% <96.29%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.89% <96.29%> (-0.02%)	⬇️
OutsideTasks	98.00% <96.29%> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
.../notification/notifiers/mixins/message/__init__.py	99.07% <96.29%> (-0.93%)	⬇️

... and 55 files with indirect coverage changes

[codecov-public-qa]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.01%. Comparing base (79f57df) to head (c1f99d8).
Report is 67 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../notification/notifiers/mixins/message/__init__.py	96.29%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         442      441       -1     
  Lines       36163    36048     -115     
==========================================
- Hits        35448    35333     -115     
  Misses        715      715              

Flag	Coverage Δ
integration	98.01% <96.29%> (-0.01%)	⬇️
unit	98.01% <96.29%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.89% <96.29%> (-0.02%)	⬇️
OutsideTasks	98.00% <96.29%> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
.../notification/notifiers/mixins/message/__init__.py	99.07% <96.29%> (-0.93%)	⬇️

... and 55 files with indirect coverage changes

[giovanni-guidini]

I think if you return nothing the PR comment would be empty.
It's better to return the default value in case there is none.

The default value is here (and it should not be lost when the YAML is processed, but merged with the user's option - I think that's the real bug)

[codecov]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.01%. Comparing base (79f57df) to head (c1f99d8).
Report is 67 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
.../notification/notifiers/mixins/message/__init__.py	96.29%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   98.02%   98.01%   -0.01%     
==========================================
  Files         442      441       -1     
  Lines       36163    36048     -115     
==========================================
- Hits        35448    35333     -115     
  Misses        715      715              

Flag	Coverage Δ
integration	98.01% <96.29%> (-0.01%)	⬇️
unit	98.01% <96.29%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	95.89% <96.29%> (-0.02%)	⬇️
OutsideTasks	98.00% <96.29%> (+<0.01%)	⬆️

Files with missing lines	Coverage Δ
.../notification/notifiers/mixins/message/__init__.py	99.07% <96.29%> (-0.93%)	⬇️

... and 55 files with indirect coverage changes

[Swatinem]

Closing this, as this was only happening in QA for our own repos, and
#890 and codecov/codecov-api#980 would fix the cause of the error.

The error is caused by comment: false as configured in the QA org is not being properly overridden when a repo yaml is only setting/overriding very specific fields of comment.