feat: make notify_error default to true in config

database/models/core.py

@@ -153,6 +153,8 @@ class Repository(CodecovBaseModel):
     owner = relationship(Owner, foreign_keys=[ownerid], back_populates="repositories")
     bot = relationship(Owner, foreign_keys=[bot_id])
 
+    created_at = Column(types.DateTime, nullable=True)
+
     __table_args__ = (
         Index("repos_slug", "ownerid", "name", unique=True),
         Index("repos_service_ids", "ownerid", "service_id", unique=True),

requirements.in

@@ -1,5 +1,5 @@
 https://github.com/codecov/opentelem-python/archive/refs/tags/v0.0.4a1.tar.gz#egg=codecovopentelem
-https://github.com/codecov/shared/archive/355b4c38a6403307719a147b70d6dcf17c29bbaf.tar.gz#egg=shared
+https://github.com/codecov/shared/archive/38444be0934c5cbdd133a790557a626c01bcb18e.tar.gz#egg=shared
 https://github.com/codecov/test-results-parser/archive/1507de2241601d678e514c08b38426e48bb6d47d.tar.gz#egg=test-results-parser
 https://github.com/codecov/timestring/archive/d37ceacc5954dff3b5bd2f887936a98a668dda42.tar.gz#egg=timestring
 asgiref>=3.7.2

requirements.txt

@@ -356,7 +356,7 @@ sentry-sdk==1.40.0
     # via
     #   -r requirements.in
     #   shared
-shared @ https://github.com/codecov/shared/archive/355b4c38a6403307719a147b70d6dcf17c29bbaf.tar.gz
+shared @ https://github.com/codecov/shared/archive/38444be0934c5cbdd133a790557a626c01bcb18e.tar.gz
     # via -r requirements.in
 six==1.16.0
     # via

services/yaml/__init__.py

@@ -3,7 +3,7 @@
 from shared.torngit.exceptions import TorngitClientError, TorngitError
 from shared.validation.exceptions import InvalidYamlException
 from shared.yaml import UserYaml
-from shared.yaml.user_yaml import OwnerContext
+from shared.yaml.user_yaml import OwnerContext, RepoContext
 
 from database.enums import CommitErrorTypes
 from database.models import Commit
@@ -16,15 +16,17 @@
 
 
 def get_repo_yaml(repository: Repository):
-    context = OwnerContext(
+    owner_context = OwnerContext(
         owner_onboarding_date=repository.owner.createstamp,
         owner_plan=repository.owner.plan,
         ownerid=repository.ownerid,
     )
+    repo_context = RepoContext(repo_creation_date=repository.created_at)
     return UserYaml.get_final_yaml(
         owner_yaml=repository.owner.yaml,
         repo_yaml=repository.yaml,
-        owner_context=context,
+        owner_context=owner_context,
+        repo_context=repo_context,
     )
 
 
@@ -100,16 +102,19 @@ async def get_current_yaml(commit: Commit, repository_service) -> dict:
             extra=dict(repoid=repository.repoid, commit=commit.commitid),
             exc_info=True,
         )
-    context = OwnerContext(
+    owner_context = OwnerContext(
         owner_onboarding_date=repository.owner.createstamp,
         owner_plan=repository.owner.plan,
         ownerid=repository.ownerid,
     )
+    repo_context = RepoContext(repo_creation_date=repository.created_at)
+
     return UserYaml.get_final_yaml(
         owner_yaml=repository.owner.yaml,
         repo_yaml=repository.yaml,
         commit_yaml=commit_yaml,
-        owner_context=context,
+        owner_context=owner_context,
+        repo_context=repo_context,
     )
 
 

tasks/sync_pull.py

@@ -13,7 +13,7 @@
 from shared.reports.types import Change
 from shared.torngit.exceptions import TorngitClientError
 from shared.yaml import UserYaml
-from shared.yaml.user_yaml import OwnerContext
+from shared.yaml.user_yaml import OwnerContext, RepoContext
 
 from app import celery_app
 from database.models import Commit, Pull, Repository
@@ -126,15 +126,17 @@ def run_impl_within_lock(
                 "pull_updated": False,
                 "reason": "no_bot",
             }
-        context = OwnerContext(
+        owner_context = OwnerContext(
             owner_onboarding_date=repository.owner.createstamp,
             owner_plan=repository.owner.plan,
             ownerid=repository.ownerid,
         )
+        repo_context = RepoContext(repo_creation_date=repository.created_at)
         current_yaml = UserYaml.get_final_yaml(
             owner_yaml=repository.owner.yaml,
             repo_yaml=repository.yaml,
-            owner_context=context,
+            owner_context=owner_context,
+            repo_context=repo_context,
         )
         with metrics.timer(f"{self.metrics_prefix}.fetch_pull"):
             enriched_pull = async_to_sync(fetch_and_update_pull_request_information)(

tasks/tests/unit/test_clean_labels_index.py

@@ -11,6 +11,7 @@
     CleanLabelsIndexTask,
     OwnerContext,
     ReadOnlyArgs,
+    RepoContext,
     ReportService,
     UserYaml,
 )
@@ -244,6 +245,7 @@ def test__get_best_effort_commit_yaml_from_db(self, dbsession, mocker):
                 owner_plan=owner.plan,
                 owner_onboarding_date=owner.createstamp,
             ),
+            repo_context=RepoContext(repo_creation_date=commit.repository.created_at),
         )
 
 

tasks/upload.py

@@ -21,7 +21,7 @@
     TorngitRepoNotFoundError,
 )
 from shared.yaml import UserYaml
-from shared.yaml.user_yaml import OwnerContext
+from shared.yaml.user_yaml import OwnerContext, RepoContext
 
 from app import celery_app
 from database.enums import CommitErrorTypes, ReportType
@@ -464,16 +464,18 @@ def run_impl_within_lock(
                 commit, repository_service
             )
         else:
-            context = OwnerContext(
+            owner_context = OwnerContext(
                 owner_onboarding_date=repository.owner.createstamp,
                 owner_plan=repository.owner.plan,
                 ownerid=repository.ownerid,
             )
+            repo_context = RepoContext(repo_creation_date=repository.created_at)
             commit_yaml = UserYaml.get_final_yaml(
                 owner_yaml=repository.owner.yaml,
                 repo_yaml=repository.yaml,
                 commit_yaml=None,
-                owner_context=context,
+                owner_context=owner_context,
+                repo_context=repo_context,
             )
 
         if report_type == ReportType.COVERAGE:

tasks/upload_clean_labels_index.py

@@ -9,7 +9,7 @@
 from shared.torngit.base import TorngitBaseAdapter
 from shared.utils.enums import TaskConfigGroup
 from shared.yaml import UserYaml
-from shared.yaml.user_yaml import OwnerContext
+from shared.yaml.user_yaml import OwnerContext, RepoContext
 
 from app import celery_app
 from database.models.core import Commit
@@ -186,16 +186,18 @@ def _get_best_effort_commit_yaml(
                 commit, repository_service
             )
         if commit_yaml is None:
-            context = OwnerContext(
+            owner_context = OwnerContext(
                 owner_onboarding_date=repository.owner.createstamp,
                 owner_plan=repository.owner.plan,
                 ownerid=repository.ownerid,
             )
+            repo_context = RepoContext(repo_creation_date=repository.created_at)
             commit_yaml = UserYaml.get_final_yaml(
                 owner_yaml=repository.owner.yaml,
                 repo_yaml=repository.yaml,
                 commit_yaml=None,
-                owner_context=context,
+                owner_context=owner_context,
+                repo_context=repo_context,
             ).to_dict()
         return commit_yaml