Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker not picking up and displaying a file for coverage on the PR comment #393

Open
rohan-at-sentry opened this issue Apr 18, 2024 · 3 comments
Assignees
Labels
Area: General UX Issues with general UX Area: PR Comment - UX Issues with the PR Comment UX bug Something isn't working Low Low Priority Issues (to be fixed or re-evaluated in 12 months

Comments

@rohan-at-sentry
Copy link

rohan-at-sentry commented Apr 18, 2024

https://sentry.slack.com/archives/C04MDUBCPHU/p1713389307029369 for context

TLDR

The UI shows a file (test_smiles.py from the tutorial) with coverage but the UI does not.

image
image

https://github.com/sdzhong/codecov-demo/pull/5/files

@giovanni-guidini
Copy link
Contributor

giovanni-guidini commented Apr 19, 2024

Looking at

for file in changed_files_with_missing_lines:

we seem to only include files with missing coverage lines in the newfiles table.
And also remaining_files is not properly initialized.

Also the newfiles section should be the 4th entry, not the 2nd one.

@thomasrockhu-codecov thomasrockhu-codecov added the bug Something isn't working label Apr 23, 2024
@rohan-at-sentry
Copy link
Author

rohan-at-sentry commented May 8, 2024

chatted with Joey on this

The key issue here is that the PR comment will only show files with at least 1 missing line. Test files usually are 100% covered so that's why it doesn't show on the PR comment

A broader question is if it needs to show up on the UI at all.. Assigning to @aj-codecov to consider.

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov to add Low, PR Comment, General UX labels

@thomasrockhu-codecov thomasrockhu-codecov added Low Low Priority Issues (to be fixed or re-evaluated in 12 months Area: PR Comment - UX Issues with the PR Comment UX Area: General UX Issues with general UX labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: General UX Issues with general UX Area: PR Comment - UX Issues with the PR Comment UX bug Something isn't working Low Low Priority Issues (to be fixed or re-evaluated in 12 months
Projects
None yet
Development

No branches or pull requests

4 participants