Remove unused import with ruff

In particular, I was interested in F401. This should clean up all unused imports in the repo.
We have to be careful with celery tasks because they don't get picked up if they are not "imported" anywhere.
I've added an annotation on the `__init__` files that import these "unused" tasks.

.gitignore

@@ -128,3 +128,6 @@ background_app/.report.json
 # Vim temporary files
 *.swp
 *.swo
+
+# Pycharm/Intellij
+.idea/

Makefile

@@ -64,17 +64,17 @@ update-requirements:
 
 lint.install:
  echo "Installing..."
- pip install -Iv black==22.3.0 isort
+ pip install -Iv ruff
 
 lint.run:
- black .
- isort --profile black .
+ ruff check --select F401 --select I . --fix
+ ruff format
 
 lint.check:
  echo "Linting..."
- black --check .
+ ruff format --check
  echo "Sorting..."
- isort --profile black --check .
+ ruff check --select F401 --select I .
 
 build.requirements:
  # if docker pull succeeds, we have already build this version of

app.py

@@ -5,7 +5,6 @@
 import django
 from celery import Celery, signals
 
-import database.events
 from helpers.logging_config import get_logging_config_dict
 from helpers.sentry import initialize_sentry, is_sentry_enabled
 

celery_config.py

@@ -3,7 +3,6 @@
 import logging
 import logging.config
 import os
-import re
 from datetime import timedelta
 
 from celery import signals

database/base.py

@@ -11,7 +11,6 @@
 
 
 class CodecovBaseModel(Base):
-
  __abstract__ = True
 
  def get_db_session(self):

database/models/reports.py

@@ -7,7 +7,6 @@
 from sqlalchemy.dialects import postgresql
 from sqlalchemy.dialects.postgresql import UUID
 from sqlalchemy.orm import backref, relationship
-from test_results_parser import Outcome
 
 from database.base import CodecovBaseModel, MixinBaseClass
 from database.models.core import Commit, CompareCommit, Repository

database/models/timeseries.py

@@ -7,7 +7,6 @@
 
 
 class TimeseriesBaseModel(CodecovBaseModel):
-
  __abstract__ = True
 
 

database/tests/factories/profiling.py

@@ -5,7 +5,6 @@
 
 
 class ProfilingCommitFactory(factory.Factory):
-
  version_identifier = factory.Faker("slug")
  repository = factory.SubFactory(RepositoryFactory)
 
@@ -14,7 +13,6 @@ class Meta:
 
 
 class ProfilingUploadFactory(factory.Factory):
-
  profiling_commit = factory.SubFactory(ProfilingCommitFactory)
 
  class Meta:

database/tests/factories/reports.py

@@ -5,7 +5,6 @@
 
 
 class RepositoryFlagFactory(factory.Factory):
-
  repository = factory.SubFactory(RepositoryFactory)
  flag_name = factory.Sequence(lambda n: f"flag{n}")
 

database/tests/factories/timeseries.py

@@ -7,7 +7,6 @@
 
 
 class MeasurementFactory(factory.Factory):
-
  owner_id = 1
  repo_id = 1
  name = "testing"
@@ -20,7 +19,6 @@ class Meta:
 
 
 class DatasetFactory(factory.Factory):
-
  repository_id = 1
  name = "testing"
  backfilled = False

database/tests/unit/test_events.py

@@ -1,8 +1,6 @@
 import os
 
-import pytest
-
-import database.events
+import database.events # noqa: F401
 from database.tests.factories import RepositoryFactory
 
 

database/tests/unit/test_model_utils.py

@@ -2,7 +2,6 @@
 from unittest.mock import PropertyMock
 
 from shared.storage.exceptions import FileNotInStorageError
-from shared.utils.ReportEncoder import ReportEncoder
 
 from database.models.core import Commit
 from database.tests.factories.core import CommitFactory
@@ -11,7 +10,6 @@
 
 class TestArchiveField(object):
  class ClassWithArchiveField(object):
-
  commit: Commit
  id = 1
  external_id = "external_id"

database/tests/unit/test_models.py

@@ -135,7 +135,6 @@ def test_updatestamp_update(self, dbsession):
 
 
 class TestReportDetailsModel(object):
-
  sample_files_array = [
  {
  "filename": "file_1.go",

database/utils.py

@@ -1,8 +1,6 @@
 import json
 import logging
 import time
-from contextlib import contextmanager
-from functools import lru_cache
 from typing import Any, Callable, Optional
 
 from shared.storage.exceptions import FileNotInStorageError

enterprise/hooks/hook-opentelemetry.py

@@ -1,3 +1,3 @@
-from PyInstaller.utils.hooks import collect_all, copy_metadata
+from PyInstaller.utils.hooks import copy_metadata
 
 datas = copy_metadata("opentelemetry-sdk")

helpers/backfills.py

@@ -8,6 +8,7 @@
 
 log = logging.getLogger(__name__)
 
+
 # GH App Backfills
 # Looping and adding all repositories in the installation app
 def add_repos_service_ids_from_provider(

helpers/checkpoint_logger/__init__.py

@@ -2,7 +2,7 @@
 import itertools
 import logging
 import time
-from enum import Enum, auto
+from enum import Enum
 from typing import (
  Any,
  Callable,
@@ -114,7 +114,9 @@ class BaseFlow(str, Enum):
  is_failure: ClassVar[Callable[[T], bool]]
  log_counters: ClassVar[Callable[[T], None]]
 
- def _generate_next_value_(name: str, start: int, count: int, last_values: list[Any]): # type: ignore[override]
+ def _generate_next_value_(
+ name: str, start: int, count: int, last_values: list[Any]
+ ): # type: ignore[override]
  """
  This powers `enum.auto()`. It sets the value of "MyEnum.A" to "A".
  """

helpers/github_installation.py

@@ -1,5 +1,3 @@
-from typing import Optional
-
 from sqlalchemy.orm import Session
 
 from database.models.core import (

helpers/pathmap/__init__.py

@@ -1,3 +1,4 @@
+# ruff: noqa: F401
 from helpers.pathmap.pathmap import _check_ancestors, _resolve_path, clean_path
 
 from .tree import Tree

helpers/pathmap/tree.py

@@ -2,8 +2,6 @@
 import operator
 from difflib import SequenceMatcher
 
-from .utils import _extract_match
-
 
 class Tree:
  def __init__(self, *args, **kwargs):

helpers/tests/unit/test_checkpoint_logger.py

@@ -1,10 +1,9 @@
 import json
 import unittest
-from enum import Enum, auto
-from unittest.mock import ANY, patch
+from enum import auto
+from unittest.mock import patch
 
 import pytest
-import sentry_sdk
 from prometheus_client import REGISTRY
 from shared.utils.test_utils import mock_metrics
 

helpers/tests/unit/test_environment.py

@@ -1,8 +1,6 @@
 import os
 from pathlib import PosixPath
 
-from shared.config import get_config
-
 from helpers.environment import (
  Environment,
  _calculate_current_env,

helpers/tests/unit/test_logging_config.py

@@ -1,5 +1,3 @@
-import os
-
 from helpers.environment import Environment
 from helpers.logging_config import (
  CustomLocalJsonFormatter,

helpers/tests/unit/test_telemetry.py

@@ -4,10 +4,7 @@
 from unittest.mock import Mock
 
 import pytest
-from shared.django_apps.pg_telemetry.models import SimpleMetric as PgSimpleMetric
-from shared.django_apps.ts_telemetry.models import SimpleMetric as TsSimpleMetric
 
-from database.models import Commit
 from database.tests.factories.core import CommitFactory, OwnerFactory, RepositoryFactory
 from helpers.telemetry import MetricContext, TimeseriesTimer, fire_and_forget
 

manage.py

@@ -1,5 +1,6 @@
 #!/usr/bin/env python
 """Django's command-line utility for administrative tasks."""
+
 import os
 import sys
 

rollouts/__init__.py

@@ -1,7 +1,5 @@
 from shared.rollouts import Feature
 
-from database.models import Owner, Repository
-
 # Declare the feature variants and parameters via Django Admin
 LIST_REPOS_GENERATOR_BY_OWNER_ID = Feature("list_repos_generator")
 

services/archive.py

@@ -4,12 +4,10 @@
 from datetime import datetime
 from enum import Enum
 from hashlib import md5
-from typing import Dict, Optional
 from uuid import uuid4
 
 from shared.config import get_config
 from shared.storage.base import BaseStorageService
-from shared.storage.exceptions import FileNotInStorageError
 from shared.utils.ReportEncoder import ReportEncoder
 
 from helpers.metrics import metrics
@@ -40,7 +38,6 @@ def get_path(self, **kwaargs) -> str:
 # Service class for performing archive operations. Meant to work against the
 # underlying StorageService
 class ArchiveService(object):
-
  """
  The root level of the archive. In s3 terms,
  this would be the name of the bucket

services/bots.py

@@ -1,7 +1,7 @@
 import logging
 import random
 from datetime import datetime, timezone
-from typing import Dict, List, Optional, Tuple, TypedDict
+from typing import Dict, List, Optional, Tuple
 
 from shared.config import get_config
 from shared.github import is_installation_rate_limited
@@ -104,9 +104,8 @@ def get_owner_installation_id(
  # using the installations to list these values
  # We have this secondary value because `deprecated_using_integration` is... deprecated
  # And might get out-of-sync soon
- ignore_installation: bool = False
+ ignore_installation: bool = False,
 ) -> Optional[Dict]:
-
  log.info(
  "Getting owner installation id",
  extra=dict(
@@ -174,7 +173,6 @@ def get_repo_appropriate_bot_token(
  repo: Repository,
  installation_info: Optional[Dict] = None,
 ) -> Tuple[Dict, Optional[Owner]]:
-
  log.info(
  "Get repo appropriate bot token",
  extra=dict(

services/comparison/__init__.py

@@ -6,10 +6,7 @@
 from shared.reports.changes import get_changes_using_rust, run_comparison_using_rust
 from shared.reports.types import Change
 from shared.torngit.exceptions import (
- TorngitClientError,
  TorngitClientGeneralError,
- TorngitError,
- TorngitObjectNotFoundError,
 )
 
 from database.enums import CompareCommitState, TestResultsProcessingError
@@ -33,7 +30,6 @@ class NotificationContext(object):
 
 
 class ComparisonProxy(object):
-
  """The idea of this class is to produce a wrapper around Comparison with functionalities that
  are useful to the notifications context.
 

services/comparison/changes.py

@@ -285,9 +285,13 @@ def iter_changed_lines(
  # we have a head line
  if line_has_changed(base_line, head_line):
  # unexpected: coverage data changed
- yield ln if yield_line_numbers else (
- base_line.coverage,
- head_line.coverage,
+ yield (
+ ln
+ if yield_line_numbers
+ else (
+ base_line.coverage,
+ head_line.coverage,
+ )
  )
  # coverage data remains the same
  else:

services/comparison/tests/unit/test_comparison_proxy.py

@@ -42,7 +42,6 @@ def make_sample_comparison(adjusted_base=False):
 
 
 class TestComparisonProxy(object):
-
  compare_url = "https://api.github.com/repos/{}/compare/{}...{}"
 
  @pytest.mark.asyncio

services/comparison/types.py

@@ -4,7 +4,7 @@
 from shared.reports.resources import Report
 from shared.yaml import UserYaml
 
-from database.models import Commit, Pull
+from database.models import Commit
 from services.repository import EnrichedPull
 
 

services/decoration.py

@@ -5,11 +5,10 @@
 from shared.config import get_config
 from sqlalchemy import func
 
-from conftest import dbsession
 from database.enums import Decoration, ReportType, TrialStatus
 from database.models import Commit, Owner, Repository
 from database.models.reports import CommitReport, Upload
-from services.billing import BillingPlan, is_pr_billing_plan
+from services.billing import is_pr_billing_plan
 from services.license import requires_license
 from services.repository import EnrichedPull
 

services/failure_normalizer.py

@@ -73,7 +73,7 @@ def __init__(
  ignore_predefined=False,
  override_predefined=False,
  *,
- key_analysis_order: Optional[List[str]] = None
+ key_analysis_order: Optional[List[str]] = None,
  ):
  flags = regex.MULTILINE
 

services/flake_detection.py

@@ -1,7 +1,6 @@
 from collections import defaultdict
 from dataclasses import dataclass
 from datetime import datetime, timedelta
-from functools import cached_property
 from logging import getLogger
 from sys import getsizeof