Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parse_raw_upload #63

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Dec 19, 2024

we want to support parsing raw upload files instead of individual JUnit
XML files

the input of this new function is the raw upload in byte form

the output is a messagepacked binary payload containing the results of
the parsing and the raw upload in readable format in byte form

Depends on: #62

@joseph-sentry joseph-sentry marked this pull request as draft December 19, 2024 22:06
we will need to handle msgpacking, base64 decoding and zlib
decompressing
we want to document the new function that we're going to implement
we want to support parsing raw upload files instead of individual JUnit
XML files

the input of this new function is the raw upload in byte form

the output is a messagepacked binary payload containing the results of
the parsing and the raw upload in readable format in byte form
@joseph-sentry joseph-sentry force-pushed the joseph/parse-raw-upload branch from 1117e75 to 7920ff8 Compare December 20, 2024 17:50
@codecov-notifications
Copy link

codecov-notifications bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/raw_upload.rs 89.28% 6 Missing ⚠️
src/testrun.rs 80.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.48%. Comparing base (996ecb2) to head (e69c111).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/raw_upload.rs 89.28% 6 Missing ⚠️
src/testrun.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   88.68%   89.48%   +0.79%     
==========================================
  Files           5        6       +1     
  Lines         707      770      +63     
==========================================
+ Hits          627      689      +62     
- Misses         80       81       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry requested a review from a team December 20, 2024 21:03
@joseph-sentry joseph-sentry marked this pull request as ready for review December 20, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant