Clean up existing indices on Upload (aka ReportSession)
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This in particular cleans up the existing indices that exist in the production DB but not in django: - `reports_upload_order_number_upload_type_report_id_index`: This index actually has the *reverse* order that the one above, which means that frequent updates to the `order_number` lead to a lot of costly index updates. - `reports_upload_report_id_f6b4ffae`: Queries on `report_id` should already been covered by the newly added index on `report_id`+`upload_type`. - `reports_upload_created_at_index`: We never query by `created_at` directly. The only place where we use this is in an `ORDER BY` that is already covered by the `report_id`.
|
Looks like the But for that case, I believe having an index would make sense, as otherwise it would do a full table scan there :-D |
adrian-codecov
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in particular cleans up the existing indices that exist in the production DB but not in django:
reports_upload_order_number_upload_type_report_id_index: This index actually has the reverse order that the one above, which means that frequent updates to theorder_numberlead to a lot of costly index updates.reports_upload_report_id_f6b4ffae: Queries onreport_idshould already been covered by the newly added index onreport_id+upload_type.reports_upload_created_at_index: We never query bycreated_atdirectly. The only place where we use this is in anORDER BYthat is already covered by thereport_id.