Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix diff-dep: only look at requirements.in + get correct base for diff #32

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

matt-codecov
Copy link
Contributor

@matt-codecov matt-codecov commented Sep 5, 2024

job failed in worker and api for a few reasons:

  • called without PR comment permissions (fixed at callsite, not here. don't know why this wasn't a problem in the test repo)
  • emitted a comparison URL for both requirements.in and requirements.txt (i only had one in the test repo, forgot to handle this)
  • using " instead of ' to quote a GHA expression expanded to invalid syntax. don't know why this wasn't a problem in the test repo

@matt-codecov matt-codecov merged commit 1f2d4d1 into main Sep 5, 2024
1 check passed
@matt-codecov matt-codecov deleted the pr32 branch September 5, 2024 20:04
@matt-codecov matt-codecov restored the pr32 branch September 5, 2024 20:04
@matt-codecov matt-codecov deleted the pr32 branch September 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants