Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add mutation to update bundle cache settings #3649

Merged
merged 2 commits into from
Jan 13, 2025
Merged

feat: Add mutation to update bundle cache settings #3649

merged 2 commits into from
Jan 13, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in a new mutation that will be used with the upcoming modal allowing users to control their bundle cache settings for a given repo.

Closes codecov/engineering-team#3154

Notable Changes

  • Add in new mutation that updates bundle cache settings
  • Add in tests

@nicholas-codecov nicholas-codecov changed the title feat: Add Nutation to update bundle cache settings feat: Add mutation to update bundle cache settings Jan 10, 2025
@codecov-staging
Copy link

codecov-staging bot commented Jan 10, 2025 •
edited
Loading

Bundle Report

Bundle size has no change ✅

@codecov-qa
Copy link

codecov-qa bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (ac9e926) to head (f58dfb4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   98.95%   98.94%   -0.01%     
==========================================
  Files         813      814       +1     
  Lines       14605    14619      +14     
  Branches     4150     4145       -5     
==========================================
+ Hits        14452    14465      +13     
- Misses        146      147       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.01%) ⬇️
Services 99.34% <100.00%> (+<0.01%) ⬆️
Shared 99.30% <ø> (-0.07%) ⬇️
UI 99.14% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...f58dfb4. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   98.95%   98.94%   -0.01%     
==========================================
  Files         813      814       +1     
  Lines       14605    14619      +14     
  Branches     4150     4152       +2     
==========================================
+ Hits        14452    14465      +13     
- Misses        146      147       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.01%) ⬇️
Services 99.34% <100.00%> (+<0.01%) ⬆️
Shared 99.30% <ø> (-0.07%) ⬇️
UI 99.14% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...f58dfb4. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (ac9e926) to head (f58dfb4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   98.95%   98.94%   -0.01%     
==========================================
  Files         813      814       +1     
  Lines       14605    14619      +14     
  Branches     4143     4145       +2     
==========================================
+ Hits        14452    14465      +13     
- Misses        146      147       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.01%) ⬇️
Services 99.34% <100.00%> (+<0.01%) ⬆️
Shared 99.30% <ø> (-0.07%) ⬇️
UI 99.14% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...f58dfb4. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (ac9e926) to head (f58dfb4).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   98.95%   98.94%   -0.01%     
==========================================
  Files         813      814       +1     
  Lines       14605    14619      +14     
  Branches     4150     4152       +2     
==========================================
+ Hits        14452    14465      +13     
- Misses        146      147       +1     
  Partials        7        7
Files with missing lines Coverage Δ
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (-0.01%) ⬇️
Services 99.34% <100.00%> (+<0.01%) ⬆️
Shared 99.30% <ø> (-0.07%) ⬇️
UI 99.14% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...f58dfb4. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f58dfb4 Fri, 10 Jan 2025 19:19:28 GMT Cloud Enterprise

@codecov Codecov
Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Bundle size has no change ✅

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 6807f02 Jan 13, 2025
58 of 62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3154-create-mutation-to-update-bundle-cache-settings branch January 13, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Create Mutation to Update Cached Bundles
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov