[chore] Add rule to make provider casing more consistent #3640

rohitvinnakota-codecov · 2025-01-08T16:26:50Z

The linter will now warn if we use Github instead of GitHub, same for GitLab. Also fixes casing errors for Bitbucket.

This closes codecov/engineering-team#3175

codecov-staging · 2025-01-08T16:29:59Z

Bundle Report

Bundle size has no change ✅

codecov-staging · 2025-01-08T16:30:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3640   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      811           
  Lines       14575    14575           
  Branches     4145     4145           
=======================================
  Hits        14422    14422           
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...hubIntegrationSection/GithubIntegrationSection.jsx	`100.00% <ø> (ø)`
...bs/Admin/ManageAdminCard/AdminTable/AdminTable.tsx	`100.00% <ø> (ø)`
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/FailedTestsTab/CodecovCLI/CodecovCLI.tsx	`100.00% <ø> (ø)`
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx	`100.00% <ø> (ø)`
...rgControlTable/RepoOrgNotFound/RepoOrgNotFound.tsx	`100.00% <ø> (ø)`
src/shared/utils/loginProviders.ts	`100.00% <ø> (ø)`
src/shared/utils/provider.ts	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...c3acdd8. Read the comment docs.

codecov-qa · 2025-01-08T16:30:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b598ce1) to head (c3acdd8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3640   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      811           
  Lines       14575    14575           
  Branches     4138     4138           
=======================================
  Hits        14422    14422           
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...hubIntegrationSection/GithubIntegrationSection.jsx	`100.00% <ø> (ø)`
...bs/Admin/ManageAdminCard/AdminTable/AdminTable.tsx	`100.00% <ø> (ø)`
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/FailedTestsTab/CodecovCLI/CodecovCLI.tsx	`100.00% <ø> (ø)`
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx	`100.00% <ø> (ø)`
...rgControlTable/RepoOrgNotFound/RepoOrgNotFound.tsx	`100.00% <ø> (ø)`
src/shared/utils/loginProviders.ts	`100.00% <ø> (ø)`
src/shared/utils/provider.ts	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...c3acdd8. Read the comment docs.

codecov-public-qa · 2025-01-08T16:30:16Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
2147	1	2146	0

View the top 1 failed tests by shortest run time

src/shared/GlobalBanners/GitHubRateLimitExceeded/GitHubRateLimitExceededBanner.test.tsx > GitHubRateLimitExceededBanner > provider is GH > renders the banner

Stack Traces | 0.11s run time

TestingLibraryElementError: Unable to find an accessible element with the role "link" and name "Github documentation."

Here are the accessible roles:

  alert:

  Name "":
  <div
    class="relative w-full border-l-4 p-4 border-orange-500 bg-orange-100 dark:bg-opacity-20"
    role="alert"
  />

  --------------------------------------------------
  heading:

  Name "Rate limit exceeded":
  <h5
    class="mb-1 font-semibold"
  />

  --------------------------------------------------
  paragraph:

  Name "":
  <p
    class="text-sm"
  />

  --------------------------------------------------
  link:

  Name "GitHub documentation.":
  <a
    class="
    font-sans cursor-pointer

    hover:underline

    focus:ring-2
   text-ds-blue-default inline-flex items-center gap-1"
    data-cy="githubRateLimitExceeded"
    data-marketing="githubRateLimitExceeded"
    data-testid="codecovGithubApp-link"
    href="https://docs.github..../rest/using-the-rest-api/rate-limits-for-the-rest-api"
    target="_blank"
  />

  --------------------------------------------------

Ignored nodes: comments, script, style
<body>
  <div>
    <div
      class="mb-2"
    >
      <div
        class="relative w-full border-l-4 p-4 border-orange-500 bg-orange-100 dark:bg-opacity-20"
        role="alert"
      >
        <svg
          class="stroke-orange-500 float-left -mt-1 mr-2 align-middle w-6 h-6"
          data-icon="exclamationTriangle"
          data-testid="exclamationTriangle"
          fill="none"
          stroke="currentColor"
          stroke-width="1.5"
          viewBox="0 0 24 24"
          xmlns="http://www.w3.org/2000/svg"
        >
          <path
            d="M12 9v3.75m-9.303 3.376c-.866 1.5.217 3.374 1.948 3.374h14.71c1.73 0 2.813-1.874 1.948-3.374L13.949 3.378c-.866-1.5-3.032-1.5-3.898 0L2.697 16.126zM12 15.75h.007v.008H12v-.008z"
            stroke-linecap="round"
            stroke-linejoin="round"
          />
        </svg>
        <h5
          class="mb-1 font-semibold"
        >
          Rate limit exceeded
        </h5>
        <p
          class="text-sm"
        >
          Unable to calculate coverage due to GitHub rate limit exceeded. Please retry later. More info on rate limits:
           
          <a
            class="
  font-sans cursor-pointer

  hover:underline

  focus:ring-2
 text-ds-blue-default inline-flex items-center gap-1"
            data-cy="githubRateLimitExceeded"
            data-marketing="githubRateLimitExceeded"
            data-testid="codecovGithubApp-link"
            href="https://docs.github..../rest/using-the-rest-api/rate-limits-for-the-rest-api"
            target="_blank"
          >
            GitHub documentation.
            <span
              class="text-ds-gray-quinary"
            >
              <svg
                class="w-4 h-4"
                data-icon=""
                data-testid=""
                fill="none"
                stroke="currentColor"
                viewBox="0 0 24 24"
                xmlns="http://www.w3.org/2000/svg"
              >
                <path
                  d="M10 6H6a2 2 0 00-2 2v10a2 2 0 002 2h10a2 2 0 002-2v-4M14 4h6m0 0v6m0-6L10 14"
                  stroke-linecap="round"
                  stroke-linejoin="round"
                  stroke-width="2"
                />
              </svg>
            </span>
          </a>
        </p>
      </div>
    </div>
  </div>
</body>
 ❯ Object.getElementError node_modules/@.../dom/dist/config.js:37:19
 ❯ node_modules/@.../dom/dist/query-helpers.js:76:38
 ❯ node_modules/@.../dom/dist/query-helpers.js:52:17
 ❯ node_modules/@.../dom/dist/query-helpers.js:95:19
 ❯ .../GlobalBanners/GitHubRateLimitExceeded/GitHubRateLimitExceededBanner.test.tsx:27:27

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

…zebo into rvinnakota/lint-rules

codecov-releaser · 2025-01-08T16:33:35Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`23172b1`	Wed, 08 Jan 2025 16:33:35 GMT	Expired	Expired
`23172b1`	Wed, 08 Jan 2025 16:33:40 GMT	Expired	Expired
`23172b1`	Wed, 08 Jan 2025 16:33:52 GMT	Expired	Expired
`23172b1`	Wed, 08 Jan 2025 16:37:33 GMT	Expired	Expired
`eb68a13`	Wed, 08 Jan 2025 16:55:37 GMT	Expired	Expired
`eb68a13`	Wed, 08 Jan 2025 16:56:15 GMT	Expired	Expired
`eb68a13`	Wed, 08 Jan 2025 16:56:48 GMT	Expired	Expired
`9cf93e9`	Wed, 08 Jan 2025 17:16:14 GMT	Expired	Expired
`9cf93e9`	Wed, 08 Jan 2025 17:16:31 GMT	Expired	Expired
`c3acdd8`	Wed, 08 Jan 2025 17:26:53 GMT	Cloud	Enterprise

codecov · 2025-01-08T16:40:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b598ce1) to head (c3acdd8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3640   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      811           
  Lines       14575    14575           
  Branches     4138     4138           
=======================================
  Hits        14422    14422           
  Misses        146      146           
  Partials        7        7

Files with missing lines	Coverage Δ
...hubIntegrationSection/GithubIntegrationSection.jsx	`100.00% <ø> (ø)`
...bs/Admin/ManageAdminCard/AdminTable/AdminTable.tsx	`100.00% <ø> (ø)`
...e/CommitCoverage/BotErrorBanner/BotErrorBanner.jsx	`100.00% <100.00%> (ø)`
.../RepoPage/FailedTestsTab/CodecovCLI/CodecovCLI.tsx	`100.00% <ø> (ø)`
...age/FailedTestsTab/GitHubActions/GitHubActions.tsx	`100.00% <ø> (ø)`
...ateLimitExceeded/GitHubRateLimitExceededBanner.tsx	`100.00% <ø> (ø)`
...rgControlTable/RepoOrgNotFound/RepoOrgNotFound.tsx	`100.00% <ø> (ø)`
src/shared/utils/loginProviders.ts	`100.00% <ø> (ø)`
src/shared/utils/provider.ts	`100.00% <ø> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`99.71% <ø> (ø)`
Pages	`98.66% <100.00%> (ø)`
Services	`99.33% <ø> (ø)`
Shared	`99.37% <ø> (ø)`
UI	`99.14% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...c3acdd8. Read the comment docs.

codecov · 2025-01-08T16:47:19Z

Bundle Report

Bundle size has no change ✅

nicholas-codecov

Small addition to the eslint rule 👀

nicholas-codecov · 2025-01-08T17:02:05Z

.eslintrc.cjs

Do we want to include Bitbucket with these rules, we may mis-case it in the opposite direction BitBucket 👀

Sure, I definitely did that before

Awesome thank you!

…zebo into rvinnakota/lint-rules

nicholas-codecov

Looks all good to me, pending the failing test (could be a flake)

adrian-codecov

🙌

rohitvinnakota-codecov and others added 5 commits January 8, 2025 11:23

Update

8427d03

Update

e2b9639

Update

4a39625

Update .eslintrc.cjs

87b0938

Update .eslintrc.cjs

46a7ccb

rohitvinnakota-codecov added 2 commits January 8, 2025 11:31

Update test

b41a88f

Merge branch 'rvinnakota/lint-rules' of https://github.com/codecov/ga…

23172b1

…zebo into rvinnakota/lint-rules

Update test

b2d30bd

rohitvinnakota-codecov and others added 3 commits January 8, 2025 11:49

Update test

7bc5f2c

Update .eslintrc.cjs

f75f86e

Update .eslintrc.cjs

eb68a13

nicholas-codecov reviewed Jan 8, 2025

View reviewed changes

rohitvinnakota-codecov added 3 commits January 8, 2025 12:09

Update rule

2678975

Merge branch 'rvinnakota/lint-rules' of https://github.com/codecov/ga…

22cb0bb

…zebo into rvinnakota/lint-rules

Update rule

9cf93e9

nicholas-codecov approved these changes Jan 8, 2025

View reviewed changes

Update tests

c3acdd8

rohitvinnakota-codecov added this pull request to the merge queue Jan 8, 2025

adrian-codecov approved these changes Jan 8, 2025

View reviewed changes

Merged via the queue into main with commit 1eaa0d6 Jan 8, 2025
62 checks passed

rohitvinnakota-codecov deleted the rvinnakota/lint-rules branch January 8, 2025 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore] Add rule to make provider casing more consistent #3640

[chore] Add rule to make provider casing more consistent #3640

rohitvinnakota-codecov commented Jan 8, 2025 •

edited

Loading

codecov-staging bot commented Jan 8, 2025

codecov-staging bot commented Jan 8, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Jan 8, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 8, 2025 •

edited

Loading

codecov-releaser commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025

nicholas-codecov left a comment

nicholas-codecov Jan 8, 2025

rohitvinnakota-codecov Jan 8, 2025

nicholas-codecov Jan 8, 2025

nicholas-codecov left a comment

adrian-codecov left a comment

[chore] Add rule to make provider casing more consistent #3640

[chore] Add rule to make provider casing more consistent #3640

Conversation

rohitvinnakota-codecov commented Jan 8, 2025 • edited Loading

codecov-staging bot commented Jan 8, 2025

Bundle Report

codecov-staging bot commented Jan 8, 2025 • edited by codecov-notifications bot Loading

Codecov Report

codecov-qa bot commented Jan 8, 2025 • edited Loading

Codecov Report

codecov-public-qa bot commented Jan 8, 2025 • edited Loading

❌ 1 Tests Failed:

codecov-releaser commented Jan 8, 2025 • edited Loading

✅ Deploy preview for gazebo ready!

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

codecov bot commented Jan 8, 2025

Bundle Report

nicholas-codecov left a comment

Choose a reason for hiding this comment

nicholas-codecov Jan 8, 2025

Choose a reason for hiding this comment

rohitvinnakota-codecov Jan 8, 2025

Choose a reason for hiding this comment

nicholas-codecov Jan 8, 2025

Choose a reason for hiding this comment

nicholas-codecov left a comment

Choose a reason for hiding this comment

adrian-codecov left a comment

Choose a reason for hiding this comment

rohitvinnakota-codecov commented Jan 8, 2025 •

edited

Loading

codecov-staging bot commented Jan 8, 2025 •

edited by codecov-notifications bot

Loading

codecov-qa bot commented Jan 8, 2025 •

edited

Loading

codecov-public-qa bot commented Jan 8, 2025 •

edited

Loading

codecov-releaser commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading