-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Success Variant Toast #3639
Conversation
Bundle ReportChanges will increase total bundle size by 610 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3639 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 811 812 +1
Lines 14575 14580 +5
Branches 4138 4146 +8
=======================================
+ Hits 14422 14427 +5
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3639 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 811 812 +1
Lines 14575 14580 +5
Branches 4138 4139 +1
=======================================
+ Hits 14422 14427 +5
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3639 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 811 812 +1
Lines 14575 14580 +5
Branches 4138 4146 +8
=======================================
+ Hits 14422 14427 +5
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3639 +/- ##
=======================================
Coverage 98.95% 98.95%
=======================================
Files 811 812 +1
Lines 14575 14580 +5
Branches 4145 4146 +1
=======================================
+ Hits 14422 14427 +5
Misses 146 146
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 610 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Description
This PR adds in a new toast variant for "success", this is required for when the user successfully updates their cache settings.
Ticket: codecov/engineering-team#3156
Notable Changes
renderToast
functionScreenshots