Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Success Variant Toast #3639

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Jan 8, 2025

Description

This PR adds in a new toast variant for "success", this is required for when the user successfully updates their cache settings.

Ticket: codecov/engineering-team#3156

Notable Changes

  • Tidy up imports for other toasts
  • Add in success toast
  • Update tests
  • Add success toast to the renderToast function

Screenshots

Screenshot 2025-01-08 at 13 00 38

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 610 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.0MB 317 bytes (0.01%) ⬆️
gazebo-staging-system-esm 6.06MB 293 bytes (0.0%) ⬆️

Copy link

codecov-public-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b598ce1) to head (957b291).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3639   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      812    +1     
  Lines       14575    14580    +5     
  Branches     4138     4146    +8     
=======================================
+ Hits        14422    14427    +5     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/toast/ErrorToast/ErrorToast.tsx 100.00% <100.00%> (ø)
src/services/toast/GenericToast/GenericToast.tsx 100.00% <100.00%> (ø)
src/services/toast/SuccessToast/SuccessToast.tsx 100.00% <100.00%> (ø)
src/services/toast/renderToast.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (ø)
Services 99.33% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...957b291. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b598ce1) to head (957b291).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3639   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      812    +1     
  Lines       14575    14580    +5     
  Branches     4138     4139    +1     
=======================================
+ Hits        14422    14427    +5     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/toast/ErrorToast/ErrorToast.tsx 100.00% <100.00%> (ø)
src/services/toast/GenericToast/GenericToast.tsx 100.00% <100.00%> (ø)
src/services/toast/SuccessToast/SuccessToast.tsx 100.00% <100.00%> (ø)
src/services/toast/renderToast.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (ø)
Services 99.33% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...957b291. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (b598ce1) to head (957b291).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3639   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      812    +1     
  Lines       14575    14580    +5     
  Branches     4138     4146    +8     
=======================================
+ Hits        14422    14427    +5     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/toast/ErrorToast/ErrorToast.tsx 100.00% <100.00%> (ø)
src/services/toast/GenericToast/GenericToast.tsx 100.00% <100.00%> (ø)
src/services/toast/SuccessToast/SuccessToast.tsx 100.00% <100.00%> (ø)
src/services/toast/renderToast.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (ø)
Services 99.33% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...957b291. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
957b291 Wed, 08 Jan 2025 15:58:31 GMT Cloud Enterprise

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3639   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         811      812    +1     
  Lines       14575    14580    +5     
  Branches     4145     4146    +1     
=======================================
+ Hits        14422    14427    +5     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
src/services/toast/ErrorToast/ErrorToast.tsx 100.00% <100.00%> (ø)
src/services/toast/GenericToast/GenericToast.tsx 100.00% <100.00%> (ø)
src/services/toast/SuccessToast/SuccessToast.tsx 100.00% <100.00%> (ø)
src/services/toast/renderToast.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <ø> (ø)
Services 99.33% <100.00%> (+<0.01%) ⬆️
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b598ce1...957b291. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will increase total bundle size by 610 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 317 bytes (0.01%) ⬆️
gazebo-production-system-esm 6.06MB 293 bytes (0.0%) ⬆️

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 0922fa3 Jan 9, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3156-add-success-variant-toast branch January 9, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants