Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cached bundle feature flag #3638

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR removes the feature flag that was introduced so these banners could be released at the same time.

Ticket: codecov/engineering-team#3153

Notable Changes

  • Remove flag from CommitBundleAnalysis and PullBundleAnalysis

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Bundle Report

Changes will decrease total bundle size by 821 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.04MB 176 bytes (-0.0%) ⬇️
gazebo-staging-system-esm* 6.06MB 469 bytes (-0.01%) ⬇️
gazebo-staging-esm 6.09MB 176 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

Copy link

codecov bot commented Jan 8, 2025

Bundle Report

Changes will decrease total bundle size by 821 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.04MB 176 bytes (-0.0%) ⬇️
gazebo-production-system-esm* 6.06MB 469 bytes (-0.01%) ⬇️
gazebo-production-esm 6.09MB 176 bytes (-0.0%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   98.95%   98.95%   -0.01%     
==========================================
  Files         813      813              
  Lines       14605    14599       -6     
  Branches     4150     4139      -11     
==========================================
- Hits        14452    14446       -6     
  Misses        146      146              
  Partials        7        7              
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (-0.01%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...14872ec. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (ac9e926) to head (14872ec).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   98.95%   98.95%   -0.01%     
==========================================
  Files         813      813              
  Lines       14605    14599       -6     
  Branches     4150     4139      -11     
==========================================
- Hits        14452    14446       -6     
  Misses        146      146              
  Partials        7        7              
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (-0.01%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...14872ec. Read the comment docs.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (ac9e926) to head (14872ec).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   98.95%   98.95%   -0.01%     
==========================================
  Files         813      813              
  Lines       14605    14599       -6     
  Branches     4150     4146       -4     
==========================================
- Hits        14452    14446       -6     
  Misses        146      146              
  Partials        7        7              
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (-0.01%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...14872ec. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (ac9e926) to head (14872ec).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   98.95%   98.95%   -0.01%     
==========================================
  Files         813      813              
  Lines       14605    14599       -6     
  Branches     4143     4139       -4     
==========================================
- Hits        14452    14446       -6     
  Misses        146      146              
  Partials        7        7              
Files with missing lines Coverage Δ
...Page/CommitBundleAnalysis/CommitBundleAnalysis.tsx 100.00% <100.00%> (ø)
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (-0.01%) ⬇️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9e926...14872ec. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 8, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7f035f6 Wed, 08 Jan 2025 12:34:57 GMT Expired Expired
14872ec Fri, 10 Jan 2025 13:37:04 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit bd76de4 Jan 10, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3153-remove-cached-bundle-feature-flag branch January 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants