Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Cache Bundle Banner to Pulls Page #3636

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in the cached bundle banner to the pulls page, when there is cached data included on the page. This is currently behind a feature flag, so it can be released at the same time as the commit page one.

Ticket: codecov/engineering-team#3153

Notable Changes

  • Add banner to commit bundle component behind a feature flag
  • Add in tests

Screenshots

Note

These screenshots are forced as there aren't any examples on staging where caching is enabled.

Screenshot 2025-01-07 at 10 10 12

@codecov-staging
Copy link

codecov-staging bot commented Jan 7, 2025

Bundle Report

Changes will increase total bundle size by 2.44kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system-esm 6.06MB 1.3kB (0.02%) ⬆️
gazebo-staging-system 6.0MB 1.13kB (0.02%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (23e4bfd) to head (4ea42c1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3636   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         811      811           
  Lines       14566    14574    +8     
  Branches     4139     4136    -3     
=======================================
+ Hits        14413    14421    +8     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...4ea42c1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3636   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         811      811           
  Lines       14566    14574    +8     
  Branches     4139     4143    +4     
=======================================
+ Hits        14413    14421    +8     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...4ea42c1. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (23e4bfd) to head (4ea42c1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3636   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         811      811           
  Lines       14566    14574    +8     
  Branches     4139     4136    -3     
=======================================
+ Hits        14413    14421    +8     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...4ea42c1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
4ea42c1 Tue, 07 Jan 2025 14:32:54 GMT Cloud Enterprise

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (23e4bfd) to head (4ea42c1).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3636   +/-   ##
=======================================
  Coverage   98.94%   98.95%           
=======================================
  Files         811      811           
  Lines       14566    14574    +8     
  Branches     4139     4136    -3     
=======================================
+ Hits        14413    14421    +8     
  Misses        146      146           
  Partials        7        7           
Files with missing lines Coverage Δ
...uestPage/PullBundleAnalysis/PullBundleAnalysis.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.66% <100.00%> (+<0.01%) ⬆️
Services 99.33% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e4bfd...4ea42c1. Read the comment docs.

Copy link

codecov bot commented Jan 7, 2025

Bundle Report

Changes will increase total bundle size by 1.27kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.0MB 634 bytes (0.01%) ⬆️
gazebo-production-system-esm 6.06MB 641 bytes (0.01%) ⬆️

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 9dde47c Jan 7, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-3153-feat-add-cached-bundle-banner-to-pulls-page branch January 7, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants